Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp20276pxk; Tue, 1 Sep 2020 15:00:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySbmxt8QEPgSa0k1pva1gY2ePFCsMHDSTCKAgKHbGxKNUR49u38mHxe6Ixj+5i+6MTrCvB X-Received: by 2002:aa7:d959:: with SMTP id l25mr3619446eds.383.1598997635725; Tue, 01 Sep 2020 15:00:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1598997635; cv=none; d=google.com; s=arc-20160816; b=ScSs5KXADTe3iyKTAIvCE+z3PrMFtTEn4O8RoasjMwjn/VLpk6VyqethF7lz1tL3+J S7GbWASBn29jEmYMaOEBqsCPxjfdCxPnQbqAIA2m/v6yVs6JJtNAeImQ6173EPrpV1E5 O1HR9g78pVd7asoI/dRumJ98R5uqyYq7E60K3AOzs0JAwxy3FNSK4vCHCzfaoAuPA6Ax II2O6hTiaD9ODsHcOiQTahwqFCxsozhho9iEBVHdlVlDGTV3rzyHMfgbES9wHm+vMcuw 3elv1re8EoSpgy/T8F3slmeyr2tMtj0HQTB+7K2xCAJG+/KztOyGYCVuPrUAnfVPRSFN aoTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=xSrVy1+KBT3QUL0M7hnVohVIvrLaQcIezS8u5q+U9tE=; b=ymLfr/bPsE1Ywn8z7G9z+JiazYb8Ywu/kcT8S/l+3P8OdEPATkhTLwuD7yNYqBNAVa gRqnhwv7ILLD95LNsBOA9nQitk1WZInuDmO/yQ5DAMDdwyMmym+IEGXM3hKQytqb0GtD vp03SViQvziROCoRurRjDPUzCHHj7FUBuYGb/RsyxYoDKQ8Oi4luaStCOsztcVc0yZny KWMhoizp0jQhrfOo6jR03cmk0wN+jD376WgZAhi9x/vvT30QQE+gotfS8lQ0gPJoQYUV bwwE7z3D0ebbkfcmT6J/6lihZSeL9P25LHCQck2lFPopkBDOcs7kDb/xkOEFpigpndja 7Tag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m18si1397055ejk.743.2020.09.01.14.59.57; Tue, 01 Sep 2020 15:00:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=siol.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728458AbgIAV6h (ORCPT + 99 others); Tue, 1 Sep 2020 17:58:37 -0400 Received: from mailoutvs49.siol.net ([185.57.226.240]:45292 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728254AbgIAV6h (ORCPT ); Tue, 1 Sep 2020 17:58:37 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id F0B71526784; Tue, 1 Sep 2020 23:58:34 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta09.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta09.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id vxLCUTGcJHyJ; Tue, 1 Sep 2020 23:58:34 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id A06835267B9; Tue, 1 Sep 2020 23:58:34 +0200 (CEST) Received: from kista.localdomain (cpe1-5-97.cable.triera.net [213.161.5.97]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPSA id C97F0526784; Tue, 1 Sep 2020 23:58:33 +0200 (CEST) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Cc: jernej.skrabec@siol.net, irlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Roman Stratiienko Subject: [PATCH] drm/sun4i: Fix DE2 YVU handling Date: Wed, 2 Sep 2020 00:03:05 +0200 Message-Id: <20200901220305.6809-1-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode but due to inproper return type (bool instead of u32) it returns just 0 or 1. Colors are wrong for YVU formats because of that. Fixes: daab3d0e8e2b ("drm/sun4i: de2: csc_mode in de2 format struct is mo= stly redundant") Reported-by: Roman Stratiienko Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c b/drivers/gpu/drm/sun= 4i/sun8i_vi_layer.c index 22c8c5375d0d..c0147af6a840 100644 --- a/drivers/gpu/drm/sun4i/sun8i_vi_layer.c +++ b/drivers/gpu/drm/sun4i/sun8i_vi_layer.c @@ -211,7 +211,7 @@ static int sun8i_vi_layer_update_coord(struct sun8i_m= ixer *mixer, int channel, return 0; } =20 -static bool sun8i_vi_layer_get_csc_mode(const struct drm_format_info *fo= rmat) +static u32 sun8i_vi_layer_get_csc_mode(const struct drm_format_info *for= mat) { if (!format->is_yuv) return SUN8I_CSC_MODE_OFF; --=20 2.28.0