Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200901120156.140522-1-jingxiangfeng@huawei.com>
In-Reply-To: <20200901120156.140522-1-jingxiangfeng@huawei.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Wed, 2 Sep 2020 00:30:09 +0000
Message-ID: <CACPK8Xe7zbYQ7UJOSqBOoj3W9kX9FkutX2H5abXf+ZQv+J+eTA@mail.gmail.com>
Subject: Re: [PATCH] fsi: Fix an IS_ERR() vs NULL check in occ_probe()
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc:     Jeremy Kerr <jk@ozlabs.org>, Eddie James <eajames@linux.ibm.com>,
        Alistair Popple <alistair@popple.id.au>,
        linux-fsi@lists.ozlabs.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 1 Sep 2020 at 12:01, Jing Xiangfeng <jingxiangfeng@huawei.com> wrote:
>
> The platform_device_register_full() function returns error pointers,
> it never returns NULL.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Thanks for the patch. I already have this change queued up for 5.10.

> ---
>  drivers/fsi/fsi-occ.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c
> index 7da9c81759ac..9eeb856c8905 100644
> --- a/drivers/fsi/fsi-occ.c
> +++ b/drivers/fsi/fsi-occ.c
> @@ -555,7 +555,7 @@ static int occ_probe(struct platform_device *pdev)
>
>         hwmon_dev_info.id = occ->idx;
>         hwmon_dev = platform_device_register_full(&hwmon_dev_info);
> -       if (!hwmon_dev)
> +       if (IS_ERR(hwmon_dev))
>                 dev_warn(dev, "failed to create hwmon device\n");
>
>         return 0;
> --
> 2.17.1
>