Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp164257pxk; Tue, 1 Sep 2020 19:59:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqN2j31StIdqPiD+nL1uM/8fI/Of9vT615XMs2qjdmtxWSFDe3gWSES/h/lcoe5S1nprzr X-Received: by 2002:a17:906:d965:: with SMTP id rp5mr4039462ejb.364.1599015576400; Tue, 01 Sep 2020 19:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599015576; cv=none; d=google.com; s=arc-20160816; b=aaq+FkkzVFVzSCU/sYIxyxpRn9gOIwGUlqXrc+/ln6Mc2bosIb9Y/11tUeyA/CAPu0 dyZXUNyw9FElcsqhe43lISvqXnsAfj3L1YJhjkgYGwHNpb37Qw9/e1E6+cuTXAo0dkZ8 Wkkg7VVZFAFXbtiqrOR0T5dSD4d2Ta3O20nTeRwODBvIVe8NkuidzxEGq0YgBBapKRCl GxiXwrlH1XG4is+M/I0QdinNbIvHE0HZbhNp4mPebK6RSoaRswf83+jqHEDxTvP6GvvY 1cGdqezLwgg/Uqa4lNOTdeG2AgdP4pVpt+rwbUVXqSYV1pEZ3q3ukJVLshXuzWN9q/QS LeBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:ironport-sdr:ironport-sdr; bh=zYKZTWI6QE6ilZgnt/rBE6f6YFUdjUOco51GN/PpzlI=; b=n40sp8WvB/4lk23PzcJnpidzc6Vot2h4n83JmmAoWElhSGJmuQInfnbowbPXvOQPLn hyAF6lV2ow+v5ndJWckbeUyW7u78+U8cIHvbTuVCf3JDlAO+GyYAabaz0QlUPK8SjMZ1 yRbVIrpw+zxFIDOJAgwdf93hPW+/Y59irQ0XlONHPytIIjU8hSQssKLt4ydI9ioG9CGI I35xXOJpiVCyJGtwrdZecROSexGyXzEeXpZh84xWFI0oUb8nsluUunCGLEEm79QHbIXm JZe+W2jLaEPP3AFaXwbo6HuVUh3ovSdR7BeZOyAJNO7EQ0L8HjZkQ45FwrUX2W5SjA3Y VW/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bo22si1657449edb.187.2020.09.01.19.59.13; Tue, 01 Sep 2020 19:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726946AbgIBC4j (ORCPT + 99 others); Tue, 1 Sep 2020 22:56:39 -0400 Received: from mga07.intel.com ([134.134.136.100]:49594 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726895AbgIBC4f (ORCPT ); Tue, 1 Sep 2020 22:56:35 -0400 IronPort-SDR: xvN2nAGEwO1/edg4nmed/KbM8GHievcZtux09SwtcDBRMgYAG+IFEd4cKAKYJxoZLsyUwQCP+3 WcDPp5Ecg3CA== X-IronPort-AV: E=McAfee;i="6000,8403,9731"; a="221528371" X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="221528371" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 19:56:35 -0700 IronPort-SDR: CHgh3Ia8+8KlG5hhGZ2zo+ve5b+pEwoy+5UJh1ZMl6iL+pcW11BqAWMmqLlXe+ArA8gc2GITAa gZfFRplep06w== X-IronPort-AV: E=Sophos;i="5.76,381,1592895600"; d="scan'208";a="477457273" Received: from bard-ubuntu.sh.intel.com ([10.239.13.33]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 19:56:31 -0700 From: Bard Liao To: alsa-devel@alsa-project.org, vkoul@kernel.org Cc: vinod.koul@linaro.org, linux-kernel@vger.kernel.org, tiwai@suse.de, broonie@kernel.org, gregkh@linuxfoundation.org, jank@cadence.com, srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com, ranjani.sridharan@linux.intel.com, hui.wang@canonical.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, mengdong.lin@intel.com, bard.liao@intel.com Subject: [PATCH 3/7] soundwire: intel: fix NULL/ERR_PTR confusion Date: Tue, 1 Sep 2020 23:02:36 +0800 Message-Id: <20200901150240.19288-4-yung-chuan.liao@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200901150240.19288-1-yung-chuan.liao@linux.intel.com> References: <20200901150240.19288-1-yung-chuan.liao@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pierre-Louis Bossart snd_soc_dai_get_sdw_stream() can only return the pointer to stream or an ERR_PTR value, NULL is not a possible value. Fixes: 09553140c8d7b ('soundwire: intel: implement get_sdw_stream() operations') Reported-by: Bard Liao Signed-off-by: Pierre-Louis Bossart Reviewed-by: Rander Wang Signed-off-by: Bard Liao --- drivers/soundwire/intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index ebca8ced59ec..bbfb86ffa653 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -1106,7 +1106,7 @@ static void *intel_get_sdw_stream(struct snd_soc_dai *dai, dma = dai->capture_dma_data; if (!dma) - return NULL; + return ERR_PTR(-EINVAL); return dma->stream; } -- 2.17.1