Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp202222pxk; Tue, 1 Sep 2020 21:31:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+nmPKCFL7KGmSShgbytNbGWz0Vsvu+iUfGfunWWScJ3jGS2UqIBw3tFx0qeL6w7mdEkW0 X-Received: by 2002:a50:8c66:: with SMTP id p93mr4833189edp.156.1599021087989; Tue, 01 Sep 2020 21:31:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599021087; cv=none; d=google.com; s=arc-20160816; b=eEszJZH9IiFnZnRxHT0ggEK7B1ZhcF9fyGX2CcqQ+epIiOh3UXaanj9QTe6uSFqCI8 8kX2GVd1+OyhY059Z6ZgcNJ+MOortf9CKYxyDOtgKoG3zLG5+jfeQ8yMjBU9tEhOAqst 2aNHTfcyJSlYIgMSgMzFAJIoN+e/FlgGANklWY5HgBMj5Hyi4qjuZ9XKWJ+gXBdp/fkf 2kOChuKO/D5sp2HUDtm/6EWDoMZn86meNw/BIAMtIZa+d8RQCZx0BMqxLKVmZ8yzwxJs ZXzTIpfXco1UyHF3KNQVxBAjOELTVagIJ1R6f+sAGrfiZ1Iit+TzbmiNEqx7YcJPqdem 2ZQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WFlzObgABu7icAn3uzuAm/8ITBBUGYFlNLAzbC9xVFs=; b=0sDZZIpmtgKKLztyMDg70KN3RpMp8hD2tcXrT8VwdVlTm0HdA/xIbxJTZKBHhk1B6D Av1gN9w5k9cDbFP3+JRdAgRfGq/IqCpEYzDFwyqEmJ18BJYCuEhspJMcaEm/HS7hgCFb 3anHjeylcWN/qyxhBCmzHvtb7b237WvWvd9twKUlkPCL4wrMLX5A4jkqSlgQjm5Q7ND9 Psug8RY+1y9PGIQkydPwv3LUMr3WixY6qBTStw+ozA6OV79/K1DZPEPen64T9U4qFJSJ nnUpFVWTGy3pnJKVSi3wjJ0s0TMQNsdDcOhrP4wvc7BdlrPDF36WLzTg8tAyrckYy1Ad 0yyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=O0ObWVsR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v10si1706824ejx.195.2020.09.01.21.31.04; Tue, 01 Sep 2020 21:31:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=O0ObWVsR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbgIBEa2 (ORCPT + 99 others); Wed, 2 Sep 2020 00:30:28 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:47818 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726380AbgIBEaX (ORCPT ); Wed, 2 Sep 2020 00:30:23 -0400 Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08240hle183608; Wed, 2 Sep 2020 00:30:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=WFlzObgABu7icAn3uzuAm/8ITBBUGYFlNLAzbC9xVFs=; b=O0ObWVsRnk6UCpCfcjeXp7IH1/pdMdkiVFJmx942qAXejP4yeiBAtFLyjXuNWEnN3pM/ nGiCywcfHRrJ1N/l1/CMYz0k5PdQcCtsYQye9MeXirxkt+KxjmPYkY+K5XgLy6vY5SP2 YD8XVl9h0ghDmezsDkGLkXDmL4COv7mgSNKDmufaQqNtdZKlx3AzsmVoqMC47mAjnbaI GyMc3vgVuRMURAvDy7acWbIl14HEh/e/HKVTEEIvkRUOvYYIQUfE4+mgkcjHZI9kM5ai lPN+wZZeJBeGx2muOM9S+3+TFz+fnpBMAKz0F89xbKOenzyFE3TsoRHxVhSnwlFSjKtu TQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 33a39xhces-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Sep 2020 00:30:02 -0400 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 08241Etl185631; Wed, 2 Sep 2020 00:30:02 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0b-001b2d01.pphosted.com with ESMTP id 33a39xhcdw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Sep 2020 00:30:02 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0824RjYC008703; Wed, 2 Sep 2020 04:30:00 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma06fra.de.ibm.com with ESMTP id 337e9h2kht-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Sep 2020 04:30:00 +0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0824TvaR31261014 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Sep 2020 04:29:57 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A1E07A405B; Wed, 2 Sep 2020 04:29:57 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3C50CA4062; Wed, 2 Sep 2020 04:29:55 +0000 (GMT) Received: from bangoria.ibmuc.com (unknown [9.199.37.120]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Wed, 2 Sep 2020 04:29:54 +0000 (GMT) From: Ravi Bangoria To: mpe@ellerman.id.au, christophe.leroy@c-s.fr Cc: ravi.bangoria@linux.ibm.com, mikey@neuling.org, paulus@samba.org, naveen.n.rao@linux.vnet.ibm.com, pedromfc@linux.ibm.com, rogealve@linux.ibm.com, jniethe5@gmail.com, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 2/8] powerpc/watchpoint: Fix handling of vector instructions Date: Wed, 2 Sep 2020 09:59:39 +0530 Message-Id: <20200902042945.129369-3-ravi.bangoria@linux.ibm.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200902042945.129369-1-ravi.bangoria@linux.ibm.com> References: <20200902042945.129369-1-ravi.bangoria@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-09-02_02:2020-09-01,2020-09-02 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 mlxlogscore=814 bulkscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009020031 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vector load/store instructions are special because they are always aligned. Thus unaligned EA needs to be aligned down before comparing it with watch ranges. Otherwise we might consider valid event as invalid. Fixes: 74c6881019b7 ("powerpc/watchpoint: Prepare handler to handle more than one watchpoint") Signed-off-by: Ravi Bangoria --- arch/powerpc/kernel/hw_breakpoint.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/kernel/hw_breakpoint.c b/arch/powerpc/kernel/hw_breakpoint.c index 9f7df1c37233..f6b24838ca3c 100644 --- a/arch/powerpc/kernel/hw_breakpoint.c +++ b/arch/powerpc/kernel/hw_breakpoint.c @@ -644,6 +644,8 @@ static void get_instr_detail(struct pt_regs *regs, struct ppc_inst *instr, if (*type == CACHEOP) { *size = cache_op_size(); *ea &= ~(*size - 1); + } else if (*type == LOAD_VMX || *type == STORE_VMX) { + *ea &= ~(*size - 1); } } -- 2.26.2