Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 2 Sep 2020 11:40:19 +0200
From:   Jessica Yu <jeyu@kernel.org>
To:     Qu Wenruo <wqu@suse.com>
Cc:     linux-kernel@vger.kernel.org, jeyu@suse.de,
        Lucas De Marchi <lucas.demarchi@intel.com>
Subject: Re: [PATCH] module: Add more error message for failed kernel module
 loading
Message-ID: <20200902094019.GA7287@linux-8ccs>
References: <20200902064619.67343-1-wqu@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200902064619.67343-1-wqu@suse.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

+++ Qu Wenruo [02/09/20 14:46 +0800]:
>When kernel module loading failed, user space only get one of the
>following error messages:
>
>- ENOEXEC
>  This is the most confusing one. From corrupted ELF header to bad
>  WRITE|EXEC flags check introduced by in module_enforce_rwx_sections()
>  all returns this error number.
>
>- EPERM
>  This is for blacklisted modules. But mod doesn't do extra explain
>  on this error either.
>
>- ENOMEM
>  The only error which needs no explain.
>
>This means, if a user got "Exec format error" from modprobe, it provides
>no meaningful way for the user to debug, and will take extra time
>communicating to get extra info.
>
>So this patch will add extra error messages for -ENOEXEC and -EPERM
>errors, allowing user to do better debugging and reporting.
>
>Signed-off-by: Qu Wenruo <wqu@suse.com>
>Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Applied, thanks.

Jessica