Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/3] dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable
 property
To:     Peter Chen <peter.chen@nxp.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "pawell@cadence.com" <pawell@cadence.com>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
References: <20200825120059.12436-1-rogerq@ti.com>
 <20200825120059.12436-3-rogerq@ti.com> <20200827111343.GB5983@b29397-desktop>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <08a7533f-b09e-f044-64e5-d709ae220599@ti.com>
Date:   Wed, 2 Sep 2020 16:28:31 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200827111343.GB5983@b29397-desktop>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Peter,

On 27/08/2020 14:14, Peter Chen wrote:
> On 20-08-25 15:00:58, Roger Quadros wrote:
>> Controller version 0x0002450D has USB2 PHY RX sensitivity issues
>> that needs to be worked around by enabling phyrst-a-enable bit
>> in PHYRST_CFG register.
>>
>> There is no way to distinguish between the controller version
>> before the device controller is started so we need to add this
>> DT property.
> 
> Maybe you should say "There is no way to know controller version
> at host mode, but this workaround needs for both host and device
> mode, so we have to add this DT property", the same for the comments
> of your driver code patch.

I will reword it to

"There is no way to know controller version before device controller
is started and the workaround needs to be applied for both host and
device modes, so we add this DT property"

cheers,
-roger

> 
> Peter
>>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>>   Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> index 7bc0263accee..e670adc955e1 100644
>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
>> @@ -58,6 +58,10 @@ properties:
>>         buffers expressed in KB
>>       $ref: /schemas/types.yaml#/definitions/uint32
>>   
>> +  cdns,phyrst-a-enable:
>> +    description: Enable resetting of PHY if Rx fail is detected
>> +    type: boolean
>> +
>>   required:
>>     - compatible
>>     - reg
>> -- 
>> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
>> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
>>
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki