Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp501453pxk; Wed, 2 Sep 2020 07:25:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsRHo91aEqn0g3FT60gPVElDguQpysRriCsFI20RDk47OE+LfuO3sM9jrQjWu2jI+XTrRH X-Received: by 2002:a05:6402:44e:: with SMTP id p14mr338611edw.1.1599056715583; Wed, 02 Sep 2020 07:25:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599056715; cv=none; d=google.com; s=arc-20160816; b=sgd+MDoC5rXDlGaOWOzksJC4HSDbrEf0A0BwefF2ph2Vc3zMPD4sIsGfgYnZBHpsFy PoM9Cn7h9O1M/sa2diIREcMtNsg7yLQbY5/vv7IU7+qDWX0c2Ffe/HFtux0GG7V1QJB+ gMLwjc/LOQHk+fraCfafOijXr/2pJcJBkJ/WhocMgeJKxQ3GEK0GIE84g3oYOlO+ABJc U6lfAwDvgCYcG/fAW2HH1eea1tj8Q7n7ZX1JTJEH/EoYmN7fdKfIgfbKK35zopJlwxR7 AcFmV7JYe3vUOLCzwHW1vlNk4Uo8XdncUlv2WT45r191in7DJZpaERsWuJPgYZ6fvvnI 7zVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=gM9T3vWDXP+R8rA9KXPhmDwJIIC+hPMMGQ6hZ5o8Ui8=; b=H7l4t+1XmRgyCg7xJ+5G+SAihOxOTVZY9qH0CNh4aH7CNrLAWeINSxNvdgwXR2XZgr yLAMnAi6nkqM6BGs5YarSgea7UZXbm+bOk+1hlNK32GDR2BuYAE3J2VVFGXbtSd9HVaH q31PQSPwNsiCHeANrdouRxDgJ7SOwvRivkJnDJBrDRctUyQLUeCKE2bKwpFWiubuYy1p r5jZfnQWSzs7uzfMIf4A+62o4pHhZUN3uPOGCtYyNayEkEktOTjfAI6MTfpzJrtQP5/F AmgeDOZXE7C4eB/Pi3TEnyVvXFfbVd+XrmAwBc2dvSfIzDCCskCozkp28I65sZMsbnuC 0vOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0BnISZH8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i24si84021edr.73.2020.09.02.07.24.52; Wed, 02 Sep 2020 07:25:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=0BnISZH8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727939AbgIBOVl (ORCPT + 99 others); Wed, 2 Sep 2020 10:21:41 -0400 Received: from mail.kernel.org ([198.145.29.99]:46188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgIBOJi (ORCPT ); Wed, 2 Sep 2020 10:09:38 -0400 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B9CC2078E; Wed, 2 Sep 2020 14:09:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599055775; bh=gM9T3vWDXP+R8rA9KXPhmDwJIIC+hPMMGQ6hZ5o8Ui8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0BnISZH8FpmdrWOwzjHoRStWKDv4AA9A++fzHBjKhNv18807g3uusiJeoMNKQym3J aANb53n4A5ZzhOj8pX8kOwQawqHjR3Ky0y0Tx9uFTjUs5Ze3ogq6ZSPSg15x2oq/ep gOHSkPNqUBUs+57a+6ZMCjWAEmYnyu6zZDSvJWEI= Date: Wed, 2 Sep 2020 16:10:00 +0200 From: Greg KH To: Antoni Przybylik Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with a function Message-ID: <20200902141000.GA2020271@kroah.com> References: <20200902132419.61220-1-antoni.przybylik@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200902132419.61220-1-antoni.przybylik@wp.pl> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 02, 2020 at 03:24:19PM +0200, Antoni Przybylik wrote: > This approach is more elegant and prevents some problems related to > macros such as operator precedence in expanded expression. > ------------------------------------------------------------------- > Changed return type to bool and removed inline sepcifier. What is this here for? Please read the documentation for how to properly version patches, it should be in the submitting patches file somewhere... thanks, greg k-h