Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2 0/2] percpu_ref & block: reduce memory footprint of
 percpu_ref in fast path
To:     Ming Lei <ming.lei@redhat.com>, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org
Cc:     Sagi Grimberg <sagi@grimberg.me>, Tejun Heo <tj@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Bart Van Assche <bvanassche@acm.org>
References: <20200902122643.634143-1-ming.lei@redhat.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <4ce7b53b-2c42-3814-fa0a-5324aca6aae0@kernel.dk>
Date:   Wed, 2 Sep 2020 08:02:30 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200902122643.634143-1-ming.lei@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/2/20 6:26 AM, Ming Lei wrote:
> Hi,
> 
> The 1st patch removes memory footprint of percpu_ref in fast path
> from 7 words to 2 words, since it is often used in fast path and
> embedded in user struct.
> 
> The 2nd patch moves .q_usage_counter to 1st cacheline of
> 'request_queue'.
> 
> Simple test on null_blk shows ~2% IOPS boost on one 16cores(two threads
> per core) machine, dual socket/numa.
> 
> V2:
> 	- pass 'gfp' to kzalloc() for fixing block/027 failure reported by
> 	kernel test robot
> 	- protect percpu_ref_is_zero() with destroying percpu-refcount by
> 	spin lock  
> 
> Ming Lei (2):
>   percpu_ref: reduce memory footprint of percpu_ref in fast path
>   block: move 'q_usage_counter' into front of 'request_queue'

Applied, thanks.

-- 
Jens Axboe