Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751047AbWEZQ3O (ORCPT ); Fri, 26 May 2006 12:29:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751052AbWEZQ3O (ORCPT ); Fri, 26 May 2006 12:29:14 -0400 Received: from pne-smtpout4-sn2.hy.skanova.net ([81.228.8.154]:28324 "EHLO pne-smtpout4-sn2.hy.skanova.net") by vger.kernel.org with ESMTP id S1751047AbWEZQ3M (ORCPT ); Fri, 26 May 2006 12:29:12 -0400 Message-Id: <20060526162900.517544000@gmail.com> References: <20060526161129.557416000@gmail.com> User-Agent: quilt/0.44-1 Date: Fri, 26 May 2006 19:11:30 +0300 From: Anssi Hannula To: Dmitry Torokhov Cc: linux-joystick@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org Subject: [patch 01/13] input: move fixp-arith.h to drivers/input Content-Disposition: inline; filename=ff-refactoring-move-fixp-arith.diff Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7188 Lines: 238 Move fixp-arith.h from drivers/usb/input to drivers/input, as the part of force feedback support that requires trigonometric functions is being moved there. hid-lgff.c is temporarily modified to avoid breaking git-bisect. Signed-off-by: Anssi Hannula --- drivers/input/fixp-arith.h | 90 +++++++++++++++++++++++++++++++++++++++++ drivers/usb/input/fixp-arith.h | 90 ----------------------------------------- drivers/usb/input/hid-lgff.c | 6 +- 3 files changed, 93 insertions(+), 93 deletions(-) Index: linux-2.6.17-rc3-git12/drivers/input/fixp-arith.h =================================================================== --- /dev/null 1970-01-01 00:00:00.000000000 +0000 +++ linux-2.6.17-rc3-git12/drivers/input/fixp-arith.h 2006-05-13 23:16:02.000000000 +0300 @@ -0,0 +1,90 @@ +#ifndef _FIXP_ARITH_H +#define _FIXP_ARITH_H + +/* + * $$ + * + * Simplistic fixed-point arithmetics. + * Hmm, I'm probably duplicating some code :( + * + * Copyright (c) 2002 Johann Deneux + */ + +/* + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + * + * Should you need to contact me, the author, you can do so by + * e-mail - mail your message to + */ + +#include + +// The type representing fixed-point values +typedef s16 fixp_t; + +#define FRAC_N 8 +#define FRAC_MASK ((1< 123.0 */ +static inline fixp_t fixp_new(s16 a) +{ + return a< -1.0 + 0x8000 -> 1.0 + 0x0000 -> 0.0 +*/ +static inline fixp_t fixp_new16(s16 a) +{ + return ((s32)a)>>(16-FRAC_N); +} + +static inline fixp_t fixp_cos(unsigned int degrees) +{ + int quadrant = (degrees / 90) & 3; + unsigned int i = degrees % 90; + + if (quadrant == 1 || quadrant == 3) { + i = 89 - i; + } + + i >>= 1; + + return (quadrant == 1 || quadrant == 2)? -cos_table[i] : cos_table[i]; +} + +static inline fixp_t fixp_sin(unsigned int degrees) +{ + return -fixp_cos(degrees + 90); +} + +static inline fixp_t fixp_mult(fixp_t a, fixp_t b) +{ + return ((s32)(a*b))>>FRAC_N; +} + +#endif Index: linux-2.6.17-rc3-git12/drivers/usb/input/fixp-arith.h =================================================================== --- linux-2.6.17-rc3-git12.orig/drivers/usb/input/fixp-arith.h 2006-05-13 23:15:00.000000000 +0300 +++ /dev/null 1970-01-01 00:00:00.000000000 +0000 @@ -1,90 +0,0 @@ -#ifndef _FIXP_ARITH_H -#define _FIXP_ARITH_H - -/* - * $$ - * - * Simplistic fixed-point arithmetics. - * Hmm, I'm probably duplicating some code :( - * - * Copyright (c) 2002 Johann Deneux - */ - -/* - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * - * Should you need to contact me, the author, you can do so by - * e-mail - mail your message to - */ - -#include - -// The type representing fixed-point values -typedef s16 fixp_t; - -#define FRAC_N 8 -#define FRAC_MASK ((1< 123.0 */ -static inline fixp_t fixp_new(s16 a) -{ - return a< -1.0 - 0x8000 -> 1.0 - 0x0000 -> 0.0 -*/ -static inline fixp_t fixp_new16(s16 a) -{ - return ((s32)a)>>(16-FRAC_N); -} - -static inline fixp_t fixp_cos(unsigned int degrees) -{ - int quadrant = (degrees / 90) & 3; - unsigned int i = degrees % 90; - - if (quadrant == 1 || quadrant == 3) { - i = 89 - i; - } - - i >>= 1; - - return (quadrant == 1 || quadrant == 2)? -cos_table[i] : cos_table[i]; -} - -static inline fixp_t fixp_sin(unsigned int degrees) -{ - return -fixp_cos(degrees + 90); -} - -static inline fixp_t fixp_mult(fixp_t a, fixp_t b) -{ - return ((s32)(a*b))>>FRAC_N; -} - -#endif Index: linux-2.6.17-rc3-git12/drivers/usb/input/hid-lgff.c =================================================================== --- linux-2.6.17-rc3-git12.orig/drivers/usb/input/hid-lgff.c 2006-05-13 23:17:47.000000000 +0300 +++ linux-2.6.17-rc3-git12/drivers/usb/input/hid-lgff.c 2006-05-13 23:18:04.000000000 +0300 @@ -37,7 +37,7 @@ #include #include "hid.h" -#include "fixp-arith.h" +//#include "fixp-arith.h" /* Periodicity of the update */ @@ -445,10 +445,10 @@ static void hid_lgff_timer(unsigned long case FF_CONSTANT: { //TODO: handle envelopes int degrees = effect->effect.direction * 360 >> 16; - x += fixp_mult(fixp_sin(degrees), + /* x += fixp_mult(fixp_sin(degrees), fixp_new16(effect->effect.u.constant.level)); y += fixp_mult(-fixp_cos(degrees), - fixp_new16(effect->effect.u.constant.level)); + fixp_new16(effect->effect.u.constant.level));*/ } break; case FF_RUMBLE: right += effect->effect.u.rumble.strong_magnitude; -- Anssi Hannula - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/