Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp542389pxk; Wed, 2 Sep 2020 08:21:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgFefHTRXHRXEybQ/6UtMZ+gI3IsBW24uNFUvOBoXRzJoAxa6kx5hPzVfwnH/D0cNz6gj9 X-Received: by 2002:a17:906:2542:: with SMTP id j2mr510820ejb.442.1599060063672; Wed, 02 Sep 2020 08:21:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599060063; cv=none; d=google.com; s=arc-20160816; b=Pc0k5kLhGJDmRC+ph/CSvX6cS/DzJd1OuxVlNmLi3wX/G6xxWlJvXtJRDK9vYQ0Yw9 3Wie4b1B7R6RLm0yVuhtoKXXvV2b/hKxeXVXMnjg3kEc/JdKtNv1fGzUZwMSgWdKo7Zh wC6mO9rUtfSnX3+4gc+sudkkihGoBRluKaCo4QNuX7hzSQPe7Tpk/H9bYQSXnKn3slSL FLZDmdb5lwAGaUYb/KG4Xx+1BODS2yq57j27v6t2M+NbQjdFo7jMphmp49R8WmaY/PSp WG3i6TfbKYrh4+GERG7DNnSgoMPLBmVthQQ+f8gxJ/Mpv8K8eTxi9a8SnV/dwI2xBPg7 o+xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=/RIdJpdWsTz7BgqxRN6c2353nieVC5YZIJx3RlKstao=; b=qFSmtSgb5jStLzxTIboXNAMyB3XUZIew3RLyZsmV+aPse3dUFYLpUNWjQpC4dNV5b0 5PjOO0ftjFWyZetlBrTUr+dZTWlJbt4EAN0f2kJgA6DzqhRcDFsTOfYlsTZ8JnlYKHAy tAYzBt5nglUlar0+N4DFjw/GuOG0CdynFSzDR9zADYN40V5jQl+7driEEwwOc7CM207v W772Q8VIbJJ6+rgMZO14kg69r6NS2wKWQWfEwreel+m3oU/VMCNLAOEGhKTjcXf8h/uK FYhAlZ95REfjx+2btbicBNXWoddH7kQAFcn6PEd1poQQqgc/ziZUXzz4BWKZ7mShKm/L ZSPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hVADfsR5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e26si2735947edc.216.2020.09.02.08.20.39; Wed, 02 Sep 2020 08:21:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=hVADfsR5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727080AbgIBPQw (ORCPT + 99 others); Wed, 2 Sep 2020 11:16:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:43876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728203AbgIBPHB (ORCPT ); Wed, 2 Sep 2020 11:07:01 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C955208DB; Wed, 2 Sep 2020 15:06:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599059220; bh=Se8Hj3xMFBUvtAoO9cPl9ShWtjIVXy/13n81smdMVtg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hVADfsR5tXkrsBk53A3KfDJmQqkVIdATa/pr2kWGoWnRzkJrIjMD55cLWnv5i2gYr RjTcv1qNX+TanBOGq3gz89vP46v3KLwP1rQxWhjkw3C1Na1kk1d4runSM+Dks5Sxjh G+nqVwSTiueLiBfvo5+4RER6uxIGrmBmh87M6L8E= From: Krzysztof Kozlowski To: Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Michal Simek , Sekhar Nori , Bartosz Golaszewski , Oleksij Rempel , Pengutronix Kernel Team , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Heiko Stuebner , Pierre-Yves MORDRET , Maxime Coquelin , Alexandre Torgue , Peter Rosin , Wolfram Sang , linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Cc: Krzysztof Kozlowski Subject: [PATCH 2/9] i2c: xiic: Simplify with dev_err_probe() Date: Wed, 2 Sep 2020 17:06:36 +0200 Message-Id: <20200902150643.14839-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200902150643.14839-1-krzk@kernel.org> References: <20200902150643.14839-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski --- drivers/i2c/busses/i2c-xiic.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 90c1c362394d..a97438f35c5d 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -787,11 +787,10 @@ static int xiic_i2c_probe(struct platform_device *pdev) init_waitqueue_head(&i2c->wait); i2c->clk = devm_clk_get(&pdev->dev, NULL); - if (IS_ERR(i2c->clk)) { - if (PTR_ERR(i2c->clk) != -EPROBE_DEFER) - dev_err(&pdev->dev, "input clock not found.\n"); - return PTR_ERR(i2c->clk); - } + if (IS_ERR(i2c->clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), + "input clock not found.\n"); + ret = clk_prepare_enable(i2c->clk); if (ret) { dev_err(&pdev->dev, "Unable to enable clock.\n"); -- 2.17.1