Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Nadav Amit <namit@vmware.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86 <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] x86/special_insn: reverse __force_order logic
Thread-Topic: [PATCH] x86/special_insn: reverse __force_order logic
Thread-Index: AQHWgSgoL1dmFxhMRECqVhfYnO9uuKlVeiqA
Date:   Wed, 2 Sep 2020 15:32:18 +0000
Message-ID: <1E3FD845-E71A-4518-A0BF-FAD31CBC3E28@vmware.com>
References: <20200901161857.566142-1-namit@vmware.com>
 <20200902125402.GG1362448@hirez.programming.kicks-ass.net>
In-Reply-To: <20200902125402.GG1362448@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <B86B4DB3C2D38C40A447546E77C04369@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a0172435-1b0f-444e-924c-08d84f556068
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2020 15:32:18.0266
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rtd0IMv/5LcI4hgmJjzFT68lCGolWthg5Wp8Wxl1pn2zADtnZJ6d5S4fHqCJw9OXgA2itWAPCoMI8UO4HoFGgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB6037
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Sep 2, 2020, at 5:54 AM, peterz@infradead.org wrote:
>=20
> On Tue, Sep 01, 2020 at 09:18:57AM -0700, Nadav Amit wrote:
>=20
>> Unless I misunderstand the logic, __force_order should also be used by
>> rdpkru() and wrpkru() which do not have dependency on __force_order. I
>> also did not understand why native_write_cr0() has R/W dependency on
>> __force_order, and why native_write_cr4() no longer has any dependency
>> on __force_order.
>=20
> There was a fairly large thread about this thing here:
>=20
>  https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Flkml=
.kernel.org%2Fr%2F20200527135329.1172644-1-arnd%40arndb.de&amp;data=3D02%7C=
01%7Cnamit%40vmware.com%7C387b68745a984454d50708d84f3f499c%7Cb39138ca3cee4b=
4aa4d6cd83d9dd62f0%7C0%7C0%7C637346480527901622&amp;sdata=3DPR%2BCUy%2FYNKz=
a6he78coaDR3x1G7BYuzFfS9SGfWZ9p8%3D&amp;reserved=3D0
>=20
> I didn't keep up, but I think the general concensus was that it's
> indeed a bit naf.

Thanks for pointer. I did not see the discussion, and embarrassingly, I hav=
e
also never figured out how to reply on lkml emails without registering to
lkml.

Anyhow, indeed, the patch that Arvind provided seems to address this issue.