Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp583185pxk; Wed, 2 Sep 2020 09:19:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyskXh1o2msuH27VmrYuyXh56uC8F0k7fYzyF4gnX9ghpfOGnmWQOniPAzovRaRuZrbi0DT X-Received: by 2002:a05:6402:1b0f:: with SMTP id by15mr779516edb.289.1599063574226; Wed, 02 Sep 2020 09:19:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599063574; cv=none; d=google.com; s=arc-20160816; b=xIdlfM3fG6h3v+XNBL/BGpJaf1votc+S6gXyULUnnGDdeH6ZPrGO5Q6Rji6l2Dnyp/ /jTx0itpmwi0+McK7Wl8m1/RJX7IKp5WUhXLyssgp0ysvyDQuYAZtL2KuZCjO4shyNgq EG75UCJuEV1PenKkV8/Y3tuSNRKswSm6mpCBAkHvLeALCIxd/SQkXfd5+FyVDMtaNf7U fHju+KVyr9TisB3YTYsJJvtcZYCoWibWNODyrqJfFseJ3OTqRNfT86bIxGcocxIErTMK NifKiodnRX55olTyoB/02cuJEYbMTBz3x4sR3VPzedjv9Z0SlY3beKMgrOxvEMVMZcNo siKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=RpoKhw1b9bKsy4+b1gLVGQSxUTdP7OrprstKv8AxQRY=; b=nHPAw6rXcPTL1KenQDq2rVJFUDs1AZ37vQKZNyo7vb+2HVsNltpgmZuxiMucw42Pka wcBSslrutX40dfrXqLij7smlwd96fVk743g1hvU8fzkEwtKc9ObmL9pd5PPVMcTnv9rQ c2gCOB9MYAMkYD60YFfIizcjPaxPRdluGRQa8PhSVEqEpiHzNtpum+r3okbIDBxbmFrH lrZ/+Ajdbd54Q4bo8L3B4eFe1l3oihUo/YVsuh6yRM51CJmXEum05zmEb9iu3eT0Fypr pJYael0VtY3AtZFtVaD8itsEqdda10+IjFT2sJ6sTkApVUMJJwUdjQs6zlablQodmAsc ATXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=geuusIYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s24si9161ejd.131.2020.09.02.09.18.55; Wed, 02 Sep 2020 09:19:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=geuusIYW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728777AbgIBQRJ (ORCPT + 99 others); Wed, 2 Sep 2020 12:17:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:53892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728291AbgIBQK4 (ORCPT ); Wed, 2 Sep 2020 12:10:56 -0400 Received: from mail.kernel.org (ip5f5ad5c3.dynamic.kabel-deutschland.de [95.90.213.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0766D2168B; Wed, 2 Sep 2020 16:10:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599063046; bh=vbQF66iKfyJ7E6H+ff93dGs/2GYrxlcC/G916kKGy4E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=geuusIYWolZAHBYtCkbEgiXNwSPLwg11C84pGwBvD5aeWsskXpag5zZz1chnORRY6 1vcg2vjCMlpdpCfC20sFlrjtKdIl3KxMGDp/+Rglaer+0YI+XkqSGFL7zQQteCPDRD nvTAQ9Io/mXWnvuvdSZpyNQRnTmrJI4mB3NJiYFA= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1kDVLQ-000tAh-8s; Wed, 02 Sep 2020 18:10:44 +0200 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 23/38] media: saa7134: avoid a shift overflow Date: Wed, 2 Sep 2020 18:10:26 +0200 Message-Id: <6ee0a9ec8855f0388fee8cd183abeb60e28b293f.1599062230.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As reported by smatch: drivers/media/pci/saa7134//saa7134-tvaudio.c:686 saa_dsp_writel() warn: should 'reg << 2' be a 64 bit type? On a 64-bits Kernel, the shift might be bigger than 32 bits. In real, this should never happen, but let's shut up the warning. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/saa7134/saa7134-tvaudio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/saa7134/saa7134-tvaudio.c b/drivers/media/pci/saa7134/saa7134-tvaudio.c index 79e1afb71075..5cc4ef21f9d3 100644 --- a/drivers/media/pci/saa7134/saa7134-tvaudio.c +++ b/drivers/media/pci/saa7134/saa7134-tvaudio.c @@ -683,7 +683,8 @@ int saa_dsp_writel(struct saa7134_dev *dev, int reg, u32 value) { int err; - audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n", reg << 2, value); + audio_dbg(2, "dsp write reg 0x%x = 0x%06x\n", + (reg << 2) & 0xffffffff, value); err = saa_dsp_wait_bit(dev,SAA7135_DSP_RWSTATE_WRR); if (err < 0) return err; -- 2.26.2