Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp583919pxk; Wed, 2 Sep 2020 09:20:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoyc5pMSEkmqDHgxSI+m/sfnc33yeaep70WD+jOvIUm3b7egZjZaoFdzD5y+75OdDE5x21 X-Received: by 2002:a17:906:a00d:: with SMTP id p13mr776521ejy.535.1599063639692; Wed, 02 Sep 2020 09:20:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599063639; cv=none; d=google.com; s=arc-20160816; b=nHGsdXoPWrV0ekewSGfyKyLyNobBBP7rNQxLSo2WsEVK+PdCRnNACGZAMi6eDQTVmv jbN04deNmhhN3qoBU2iRj/Ct1K9YVXXyYqbmYI0xW4nCUmX8ZoNfndmWEyWwWuj7NOFB Oi6Xr/irI9RhuORPBaAFqg1IvpKrA9T04+ez8RInYlybMHj1N/Xm8FCpQznFFefUJqu1 t/0SUAht1GxNeIFX889HA0geeswZbwu5oam5P1JgoWXUbNg1ccvyjfpnvU1TGov0MyJS nyxObB0MWGYSxmnGtFDaK1y5QhESFw6ezWv8aKLMNbU82H5aEmTEqfdjx0S1pw0lYn+K Yg8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=z/MqJvOjm3PVGuSlKnLiQQt8fbfrwbiHlYfgOnNG/C4=; b=Ng9nCq+R1DpZ2EoeKZNVF/2IN2+fJCgBTm2XF0UUGieTeLoKmc4TcvBGlVpBnJqoR0 /1NPjG4ZmCKJb/svWyKjEneMyzPbJ6rBHU9F7dwuGankI9widEJk3o2VGBrDNXZGa2Oo HNs9kRFiaPO7kFcveejXxo2Tx4Evox4KjdhNthTWc5c5n/rvN7L2ig0Uez1qMwTrEltn VS9/EFJ4mDo0wp7GYPM6xdVX3BvjPEkuKWVu/afiLny9f8zMApIb0HnBZdNkU9qYx5fW tOxLebjhiqUOCkigydZlNWxMv0zDa2p6XWXp6lRItGWGVadjJFRXqM8s1S81fXig2DsK gX6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=KPXDst8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d7si2778024ejc.635.2020.09.02.09.20.16; Wed, 02 Sep 2020 09:20:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=KPXDst8O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728833AbgIBQQO (ORCPT + 99 others); Wed, 2 Sep 2020 12:16:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:53920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728298AbgIBQK4 (ORCPT ); Wed, 2 Sep 2020 12:10:56 -0400 Received: from mail.kernel.org (ip5f5ad5c3.dynamic.kabel-deutschland.de [95.90.213.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01CC121655; Wed, 2 Sep 2020 16:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599063046; bh=b420j7CBfw+D7BCOVF5+bODRBG1RaeqpINVSfggl6cE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KPXDst8O/wmDHu+mZOBICcXK6SsLeS4lRAFzqVEjNvhkxaSPDWpQK5psdnjLg83uC YLbpql3wJ8xPR3VGyuVWxIayNGl0w0PgSCzn/CrzkYHQVfaO/jjT4qjWo7DI+7nvo2 kzRYXviFdwBL/aozuC3oVeBV9lmVTvIwalEd33P0= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1kDVLQ-000tAZ-5s; Wed, 02 Sep 2020 18:10:44 +0200 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Takashi Iwai , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 20/38] media: saa7134-alsa.c: number of pages should be unsigned long Date: Wed, 2 Sep 2020 18:10:23 +0200 Message-Id: <7e9ce5335675f4e81fd28e2e57451c58d2ebb5bb.1599062230.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As reported by smatch: drivers/media/pci/saa7134/saa7134-alsa.c:267 saa7134_alsa_dma_init() warn: should 'nr_pages << 12' be a 64 bit type? the number of patches should be unsigned long. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/saa7134/saa7134-alsa.c | 7 ++++--- drivers/media/pci/saa7134/saa7134.h | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/media/pci/saa7134/saa7134-alsa.c b/drivers/media/pci/saa7134/saa7134-alsa.c index 544ca57eee75..347ecb0bab2f 100644 --- a/drivers/media/pci/saa7134/saa7134-alsa.c +++ b/drivers/media/pci/saa7134/saa7134-alsa.c @@ -252,7 +252,8 @@ static int snd_card_saa7134_capture_trigger(struct snd_pcm_substream * substream return err; } -static int saa7134_alsa_dma_init(struct saa7134_dev *dev, int nr_pages) +static int saa7134_alsa_dma_init(struct saa7134_dev *dev, + unsigned long nr_pages) { struct saa7134_dmasound *dma = &dev->dmasound; struct page *pg; @@ -260,11 +261,11 @@ static int saa7134_alsa_dma_init(struct saa7134_dev *dev, int nr_pages) dma->vaddr = vmalloc_32(nr_pages << PAGE_SHIFT); if (NULL == dma->vaddr) { - pr_debug("vmalloc_32(%d pages) failed\n", nr_pages); + pr_debug("vmalloc_32(%lu pages) failed\n", nr_pages); return -ENOMEM; } - pr_debug("vmalloc is at addr %p, size=%d\n", + pr_debug("vmalloc is at addr %p, size=%lu\n", dma->vaddr, nr_pages << PAGE_SHIFT); memset(dma->vaddr, 0, nr_pages << PAGE_SHIFT); diff --git a/drivers/media/pci/saa7134/saa7134.h b/drivers/media/pci/saa7134/saa7134.h index 77c325e64a97..d29499cd7370 100644 --- a/drivers/media/pci/saa7134/saa7134.h +++ b/drivers/media/pci/saa7134/saa7134.h @@ -509,7 +509,7 @@ struct saa7134_dmasound { void *vaddr; struct scatterlist *sglist; int sglen; - int nr_pages; + unsigned long nr_pages; unsigned int dma_blk; unsigned int read_offset; unsigned int read_count; -- 2.26.2