Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp584072pxk; Wed, 2 Sep 2020 09:20:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwIzAsgFtSsYTGbVs4qfzQrh4X5I4IGfoen5raCDPnK/9o7ld9fu1dR/n3orzQ8I8atWLUA X-Received: by 2002:a17:906:b7d1:: with SMTP id fy17mr781361ejb.391.1599063654943; Wed, 02 Sep 2020 09:20:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599063654; cv=none; d=google.com; s=arc-20160816; b=SvloDVXWbaQwWrOxgXCfF4c7i4A/p5ynrKSwTAN+RCZDMaQN8rLng1DafQQos7zT+C leuUF+EKLWE83QrJDXmZnnzJVL1AwggMGkRJA8cLiFeSTIPOUMR9vlk4BGnKpNedYJh/ spG6ZjxdLnu/Y1q5rZiuCeXjsrp2+B9MrHLsPdNKUddbgso3R+w9wlwJ1+xXuRZ/X/48 4MKRMfz/HunKyjfpUJ0NqWSK9SP0iToPtQzWVSa6OzUXMn7MkfmB+Sjq3m/+Hn4Ye+xO gXjRfQFqHIZwLUqz4fjJ74dVdkQ1x33dGq7oPmiKvfajMTVLCX+3IdUDY4dBrNq2h4Ib /5UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=pcn57Tu2qKfDMCTAFVzDbwqfJowRKTNzB2paqiPLHyI=; b=cpTScYFDnmBUalN2C4Hja4Ha/qeo2679AFFREpLk8GOvpGjMJOXxw3ZmTHemJ98kcw +7UZQmUgQc/8zKO/c5DjJj2cJeuUsSrMqbOnXAEzU5ZWhpMU7WQCKbFxT6ncYHpQJ1ST pyRhcjIl5F5UmMfH17tsywAhMknr1PMadsxBEyMgye9hQ+ahTEbytKFa++4JkWaEAa2e hW09e10hFMjRjEU/KjN5PEojwaQp3+2kM6eECJl7uXo06E5x0cSUHdOdNyXdOsFcyEol EZ/5Joxi2aUGciENWDlDeCDQ0E7qdm+h7T3n7xVeeqKXvBvPVG9ehrnSIq+vcajj0Q+X hngw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=pdpEcpkn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r17si2714ejz.238.2020.09.02.09.20.31; Wed, 02 Sep 2020 09:20:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=pdpEcpkn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728783AbgIBQSP (ORCPT + 99 others); Wed, 2 Sep 2020 12:18:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:53872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727991AbgIBQKs (ORCPT ); Wed, 2 Sep 2020 12:10:48 -0400 Received: from mail.kernel.org (ip5f5ad5c3.dynamic.kabel-deutschland.de [95.90.213.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD2D8214F1; Wed, 2 Sep 2020 16:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599063046; bh=5Br08z5EHU347ymKSVPsmlv2b1oAPGH5xsj10Ivzd+8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pdpEcpknJFkU98IyHqqtNNK8vHKCDK0nq3a+OkyxFNbyCbTCQyyGL5Ajo3M8HPjgz 2g1iOTnZcQzciGbRcyzqKXOPHvz9khZunuLBu0QXWgSZogk89TsPpXZalTCXReJtNY Q/xKMs1oqd2OMMfJZX6q+NDBemfgpYi57uGkYCFI= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1kDVLP-000t9p-Nq; Wed, 02 Sep 2020 18:10:43 +0200 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/38] media: av7110_v4l: avoid a typecast Date: Wed, 2 Sep 2020 18:10:07 +0200 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While smatch reports an issue there: drivers/media/pci/ttpci/av7110_v4l.c:163 ves1820_set_tv_freq() warn: unsigned 'freq' is never less than zero. drivers/media/pci/ttpci/av7110_v4l.c:165 ves1820_set_tv_freq() warn: unsigned 'freq' is never less than zero. The logic is actually fine. Yet, removing the typecast shuts up smatch and makes the code more readable. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/pci/ttpci/av7110_v4l.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/pci/ttpci/av7110_v4l.c b/drivers/media/pci/ttpci/av7110_v4l.c index cabe006658dd..6d9c908be713 100644 --- a/drivers/media/pci/ttpci/av7110_v4l.c +++ b/drivers/media/pci/ttpci/av7110_v4l.c @@ -160,9 +160,9 @@ static int ves1820_set_tv_freq(struct saa7146_dev *dev, u32 freq) buf[1] = div & 0xff; buf[2] = 0x8e; - if (freq < (u32) (16 * 168.25)) + if (freq < 16U * 168.25) config = 0xa0; - else if (freq < (u32) (16 * 447.25)) + else if (freq < 16U * 447.25) config = 0x90; else config = 0x30; -- 2.26.2