Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp584484pxk; Wed, 2 Sep 2020 09:21:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFR0fVvSREdAfB1zgp6GET+JYZV7VQv5//bF3zws94XbtB753qedFIYVqipvwPIfzK7qMt X-Received: by 2002:a17:906:2542:: with SMTP id j2mr784245ejb.442.1599063688505; Wed, 02 Sep 2020 09:21:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599063688; cv=none; d=google.com; s=arc-20160816; b=fXCh3+Ksv7HqjlRI3v9DPgUnOgPT9/RDDaah+jkd8nbuxBTd3mVz6024LK66yeAZWt 83aDdjemACarmxXXc/ydQBlK1jZcpohsLiV5xRpy91H4O0j9zkbaoo5IloR3BZ+Ou+V+ 37x8ERTsqHuTye8sUNBjA/Kj4XV7Z9GONVFL0qFj8eK1vm5+QdyofvcZUdeS8oFg87ok sSyA5MrVdcAFPmffLF8x5x+pIsDlIRYgMIF+PzHuJHrfBfBBT8FrGB1pAK4hX6bgXvyV N6kVIqQ9OsVWKQ0MTUppQfRr8x149yhQkoc3rVhrj9fs2YDGaas8fS/bjh+oQO9fNy/1 lovg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=yWpqsJb5hlP9HZvw2prC0LOERo1mslVJ4a56AniDgUw=; b=jwloyDF5fkepP6isbOKEaXtgNLwwSQ+oI5+74sLPR+HXoGPCEbkgA/elPaH/06xol/ gOVInE0cJVPvS2IuvjzvHKao/kZyySrGtHpP2lF0nIbV2Xiq9Ly7jUCzBBCYg+aGHQsD Xl8evza8N3tGL63lidSpZOyiMkZ8CrovYeq90G2feZuf8dKka8sL4htdA0bk30d3UOA+ CF2nagPvfjspmWuT0COhnZI7CucNwvltI32iSDB5tTNgihltwxLMMFu42B6uE0tnPBry EC5l2luyWRKmsQCqKiPtjBQyLlyx/ZzyhW2V6V7PI+NiVbmiwkUsyOtgZHG3/uL67yx8 38Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ai+8YXn0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si2912293edu.323.2020.09.02.09.21.04; Wed, 02 Sep 2020 09:21:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ai+8YXn0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgIBQRP (ORCPT + 99 others); Wed, 2 Sep 2020 12:17:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:57742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728756AbgIBQRE (ORCPT ); Wed, 2 Sep 2020 12:17:04 -0400 Received: from embeddedor (187-162-31-110.static.axtel.net [187.162.31.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 607D220639; Wed, 2 Sep 2020 16:17:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599063424; bh=737eL5OJnps+Fgda6I/02laUfr4yPyternnQSNU90a0=; h=Date:From:To:Cc:Subject:From; b=ai+8YXn0v79UX78y4IXY2HWQ5Bt6T6zyzZQlahXCcyiagM/Z9NIXdZY7Fm3rms1xl hpgsXBGEVeTa09MJcILzKm9XOjrsX1qUOQcq2GiAScX+HtZHzLMJkmAdLayUo4e6IR EV67gJrXzXM3MbDr4TCpX5V1mgs/HXSVGLutSoxI= Date: Wed, 2 Sep 2020 11:23:15 -0500 From: "Gustavo A. R. Silva" To: Sebastian Reichel , Jonathan Bakker , Krzysztof Kozlowski , Jonghwa Lee , Randy Dunlap Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH v2] power: supply: charger-manager: Fix info message in check_charging_duration() Message-ID: <20200902162315.GA11384@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A few months ago, commit e132fc6bb89b ("power: supply: charger-manager: Make decisions focussed on battery status") changed the expression in the if statement from "duration > desc->discharging_max_duration_ms" to "duration > desc->charging_max_duration_ms", but the arguments for dev_info() were left unchanged. Apparently, due to a copy-paste error. Fix this by using the proper arguments for dev_info(). Also, while there, replace "exceed" with "exceeds", for both messages. Addresses-Coverity-ID: 1496803 ("Copy-paste error") Fixes: e132fc6bb89b ("power: supply: charger-manager: Make decisions focussed on battery status") Signed-off-by: Gustavo A. R. Silva --- Changes in v2: - Replace "exceed" with "exceeds" drivers/power/supply/charger-manager.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c index 07992821e252..a6d5dbd55e37 100644 --- a/drivers/power/supply/charger-manager.c +++ b/drivers/power/supply/charger-manager.c @@ -464,7 +464,7 @@ static int check_charging_duration(struct charger_manager *cm) duration = curr - cm->charging_start_time; if (duration > desc->charging_max_duration_ms) { - dev_info(cm->dev, "Charging duration exceed %ums\n", + dev_info(cm->dev, "Charging duration exceeds %ums\n", desc->charging_max_duration_ms); ret = true; } @@ -472,8 +472,8 @@ static int check_charging_duration(struct charger_manager *cm) duration = curr - cm->charging_end_time; if (duration > desc->charging_max_duration_ms) { - dev_info(cm->dev, "Discharging duration exceed %ums\n", - desc->discharging_max_duration_ms); + dev_info(cm->dev, "Charging duration exceeds %ums\n", + desc->charging_max_duration_ms); ret = true; } } -- 2.27.0