Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp584620pxk; Wed, 2 Sep 2020 09:21:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQ+kUja0ixb3FsTVZdp+ul8XNhoJRJ7wmoX6qyvK2HOOG4jMHFs5lg8sTHwhX//YN9X8bo X-Received: by 2002:a50:ee15:: with SMTP id g21mr844180eds.47.1599063703222; Wed, 02 Sep 2020 09:21:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599063703; cv=none; d=google.com; s=arc-20160816; b=D6eVfTOipyAJdkLLKrhx1MqpwuB/fZL4EHIOi4DpSquHS12iBN1K7mVsBXI5GzPOwh oM95b9aG/daNjlo+IUfRiBMa5t0LhO14KANsNQP5xuF3hxIjq7RGYi3Dko1mIlJ66dEm 6KZWdxD5frzad4U4wk+lHCWJ+9s+jkpXTAq9HNgvJmxClxk/WXZ75qa0KHFFzDxubGEX oR0x19h18Gho2wx9sxX2KHj1POghFKE5+jUzr7+khi/NUHG7cIYTKUsWFQP0AD+3Yvb6 oTA/QQzp5dqgDOoPm/JQjnecwqhKBtYjdwmQHT1elcOZZPnLKjfE6QCWoBoti3++Lo9A vwng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=fVSUClj9+cxiD9L97OBUTdN2KxtplhPE5+2zEXHFlMA=; b=vR3t8+Nuo0zfdtqgwIXgWZNUa4n6oJYu7jEMZj23sJCr8xHeG3dIdsJA7AWxwyE7eh mZ8VzzklLK2WW6cqXmnNR/BUozkdbH4SsGauJC0upr5x/43NscovyKXsj62XXMFfmuIy gT2AJJmnSBd5WBgL55Z8X6+Qs9eDA5OSKakNa3WxF+Y/SCGIUL7VV6VBpSyNe/CNgX5T rAE0c5wMSF0VJV2PohOSAimw90Rt7gAq9bVKrmm4jfJQwJ1nH98BMVdiN48x+KvoK9x8 SDUwsa2SSneraZxdqGEKqd1WkcpIcSruJabkifKlVZHejQmy8WRd2U4i3H79GEcqyQGu sweg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=y4CnJRus; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j20si2815098edt.233.2020.09.02.09.21.19; Wed, 02 Sep 2020 09:21:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=y4CnJRus; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728869AbgIBQRe (ORCPT + 99 others); Wed, 2 Sep 2020 12:17:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:53922 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728152AbgIBQKv (ORCPT ); Wed, 2 Sep 2020 12:10:51 -0400 Received: from mail.kernel.org (ip5f5ad5c3.dynamic.kabel-deutschland.de [95.90.213.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E355221527; Wed, 2 Sep 2020 16:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599063046; bh=+2RR6roDnn65j3iO36CYLbDLclz+0rrWulMZeG9XTOk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=y4CnJRus8XbEmh08o5k7WLby+AoyTlP/estB+zYDEA8ccRF3QXheYEh094E8DV+oD bhyXKWq1gnCqgoieLbaTEjMlSLl1StG435UgWv8JT1y1mDhyYMRvJY0nGXouLtiEH7 HGxkbVHeoqZR6rVHIdjZ6uzjJmqTYNiqoCkXUTKE= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1kDVLQ-000tAL-1s; Wed, 02 Sep 2020 18:10:44 +0200 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/38] media: vivid: fix error path Date: Wed, 2 Sep 2020 18:10:18 +0200 Message-Id: <276afb2977c68e7d9e8d8d90237abff8ed2cd21c.1599062230.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If something fails after calling v4l2_device_register(), it should call v4l2_device_put(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/test-drivers/vivid/vivid-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/test-drivers/vivid/vivid-core.c b/drivers/media/test-drivers/vivid/vivid-core.c index 54df7e0c13fc..48809991f037 100644 --- a/drivers/media/test-drivers/vivid/vivid-core.c +++ b/drivers/media/test-drivers/vivid/vivid-core.c @@ -1698,10 +1698,8 @@ static int vivid_create_instance(struct platform_device *pdev, int inst) &has_tuner, &has_modulator, &ccs_cap, &ccs_out, in_type_counter, out_type_counter); - if (ret) { - kfree(dev); - return ret; - } + if (ret) + goto free_dev; vivid_set_capabilities(dev); -- 2.26.2