Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp584807pxk; Wed, 2 Sep 2020 09:22:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrytD0d09pcfFqq2QRGqbI+eBX7ksuArZu8aoVrZ74HxOuK7B5yYxo+MjhfBcrvVA0TEv3 X-Received: by 2002:a17:906:b74a:: with SMTP id fx10mr800026ejb.232.1599063721994; Wed, 02 Sep 2020 09:22:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599063721; cv=none; d=google.com; s=arc-20160816; b=uMIKNZaZ+SBTBJpZFvK5wJwTKWuDPNELA4BW8o4rSyWQMjLISXAV9NfXTvw9s6pL3n IQWAWI2b0zmXCGA7F/OZxdKBe7eEJwHlPqmiGtLr24++afs3+dklbKqUKmVwt5eHbivd tNDmBeeP5lMMqlk+tx+ZZKUolMMXQf5f08Nm+602XMySb02VLyezNPCJeuKxWreGRkPe 8kHfELMNCakxHoOZfd9vKbu2nxJQmBm6qNu7FRuqnK2XTaBzgzQjVDGmgStdq5LdIwhj +Hmw2xQLNoUA1+WgxyxXdXu9NAHtlaPHePhw8fH1C95aK8/03gFuUycB0IgyVEQTI0Lz s5Ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from :dkim-signature; bh=gwe1ewMWcNDluqXMQBWHfDMZumQWL/sfnioSBvwjlRs=; b=abf1rtWYGjT0KLKjsY6tVqW11AKczzPmGnVmr6xNQARlpxTVcQp63rro/IYjW/bjFn u0IiQN6AkZrS+KmSXRzY9Bjj/YPZCrDOAgU4dU+hyQ6n6xEFcR7/9saFEaLDhbNV4FsE mItJep3zgrlRwzw5kqQAl9tyuNYhRYSGcwUMYSfRpctjAYFyrVFRqdnV2MWw18dxgCJ+ GJwzuGJ0ioR4Kk3d9yFFcesUcBMtyOcWqFjCQFTUyEXUAXh92nEyWcU0NUVcNaKuzCH4 WnqIAOFBedeBh8Bii6zWhYcugybaRyHyKCSTYC7agx/10pA2gC9FXHrJ00l2GMQwrPpu yqvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=VA1GN01h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o21si479ejg.255.2020.09.02.09.21.38; Wed, 02 Sep 2020 09:22:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=default header.b=VA1GN01h; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728654AbgIBQRa (ORCPT + 99 others); Wed, 2 Sep 2020 12:17:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:53892 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728045AbgIBQKv (ORCPT ); Wed, 2 Sep 2020 12:10:51 -0400 Received: from mail.kernel.org (ip5f5ad5c3.dynamic.kabel-deutschland.de [95.90.213.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DAC322145D; Wed, 2 Sep 2020 16:10:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599063046; bh=0Hj7ZIEL0P3+LazNj3oWTUDc18jn9Tcv84+tSkI0Wtg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VA1GN01hnAbujexln0WXKOHjK5Pa4EMpteFO/qoRPoLo700l4eXmKSgDC8ry2xvJe NbCw3PqKHFOy/OHBHi5tSYUBkXpBmk16gxahSRl3o9FGd0SSMMBP9faddVrPmsk4z1 +86S5WrUxcqj1cz+be5EXucse5DHu9lzZ38p3nds= Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1kDVLP-000t9w-QL; Wed, 02 Sep 2020 18:10:43 +0200 From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/38] media: tda10021: avoid casts when using symbol_rate Date: Wed, 2 Sep 2020 18:10:10 +0200 Message-Id: <316f5e497a02dc245953134f22cfb70aa67ccd26.1599062230.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The usage of castings and float point when checking for the setup based at the symbol_rate cause those warnings with smatch: drivers/media/dvb-frontends/tda10021.c:153 tda10021_set_symbolrate() warn: unsigned 'symbolrate' is never less than zero. drivers/media/dvb-frontends/tda10021.c:155 tda10021_set_symbolrate() warn: unsigned 'symbolrate' is never less than zero. drivers/media/dvb-frontends/tda10021.c:157 tda10021_set_symbolrate() warn: unsigned 'symbolrate' is never less than zero. drivers/media/dvb-frontends/tda10021.c:159 tda10021_set_symbolrate() warn: unsigned 'symbolrate' is never less than zero. While the code should work with gcc, as it will evaluate the values into a constant before compiling, other compilers could do otherwise. So, get rid of float pointing math on it, avoiding the need of doing typecasts. While here, cleanup some coding style issues at the related code. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/tda10021.c | 38 ++++++++++++++++---------- 1 file changed, 24 insertions(+), 14 deletions(-) diff --git a/drivers/media/dvb-frontends/tda10021.c b/drivers/media/dvb-frontends/tda10021.c index 9fb207b41576..faa6e54b3372 100644 --- a/drivers/media/dvb-frontends/tda10021.c +++ b/drivers/media/dvb-frontends/tda10021.c @@ -137,26 +137,36 @@ static int tda10021_set_symbolrate (struct tda10021_state* state, u32 symbolrate { s32 BDR; s32 BDRI; - s16 SFIL=0; + s16 SFIL = 0; u16 NDEC = 0; u32 tmp, ratio; - if (symbolrate > XIN/2) - symbolrate = XIN/2; - if (symbolrate < 500000) + if (symbolrate > XIN / 2) + symbolrate = XIN / 2; + else if (symbolrate < 500000) symbolrate = 500000; - if (symbolrate < XIN/16) NDEC = 1; - if (symbolrate < XIN/32) NDEC = 2; - if (symbolrate < XIN/64) NDEC = 3; + if (symbolrate < XIN / 16) + NDEC = 1; + if (symbolrate < XIN / 32) + NDEC = 2; + if (symbolrate < XIN / 64) + NDEC = 3; - if (symbolrate < (u32)(XIN/12.3)) SFIL = 1; - if (symbolrate < (u32)(XIN/16)) SFIL = 0; - if (symbolrate < (u32)(XIN/24.6)) SFIL = 1; - if (symbolrate < (u32)(XIN/32)) SFIL = 0; - if (symbolrate < (u32)(XIN/49.2)) SFIL = 1; - if (symbolrate < (u32)(XIN/64)) SFIL = 0; - if (symbolrate < (u32)(XIN/98.4)) SFIL = 1; + if (symbolrate < XIN * 10 / 123) + SFIL = 1; + if (symbolrate < XIN * 10 / 160) + SFIL = 0; + if (symbolrate < XIN * 10 / 246) + SFIL = 1; + if (symbolrate < XIN * 10 / 320) + SFIL = 0; + if (symbolrate < XIN * 10 / 492) + SFIL = 1; + if (symbolrate < XIN * 10 / 640) + SFIL = 0; + if (symbolrate < XIN * 10 / 984) + SFIL = 1; symbolrate <<= NDEC; ratio = (symbolrate << 4) / FIN; -- 2.26.2