Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <be80ceda-596b-03aa-394f-166cc6388aa0@infradead.org>
In-Reply-To: <be80ceda-596b-03aa-394f-166cc6388aa0@infradead.org>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Thu, 3 Sep 2020 01:46:51 +0900
Message-ID: <CAK7LNAQekh08D6=+CqRWiB7F4KCLOgSK9oof8ArVUvMc7B1YXQ@mail.gmail.com>
Subject: Re: [PATCH] kconfig: streamline_config.pl: check defined(ENV
 variable) before using it
To:     Randy Dunlap <rdunlap@infradead.org>,
        Nathan Royce <nroycea+kernel@gmail.com>
Cc:     linux-kbuild <linux-kbuild@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Changbin Du <changbin.du@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Aug 27, 2020 at 6:21 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
> A user reported:
> 'Use of uninitialized value $ENV{"LMC_KEEP"} in split at
>  ./scripts/kconfig/streamline_config.pl line 596.'
>
> so first check that $ENV{LMC_KEEP} is defined before trying
> to use it.
>
> Fixes: c027b02d89fd ("streamline_config.pl: add LMC_KEEP to preserve some kconfigs")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Changbin Du <changbin.du@gmail.com>
> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> ---


Applied to linux-kbuild/fixes with Nathan's tag

Reported-by: Nathan Royce <nroycea+kernel@gmail.com>


Nathan,
I think adding your tag is OK to credit your contribution.
Please let me know if you do not have it in
the commit log.


>  scripts/kconfig/streamline_config.pl |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> --- linux-next-20200825.orig/scripts/kconfig/streamline_config.pl
> +++ linux-next-20200825/scripts/kconfig/streamline_config.pl
> @@ -593,7 +593,10 @@ while ($repeat) {
>  }
>
>  my %setconfigs;
> -my @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> +my @preserved_kconfigs;
> +if (defined($ENV{'LMC_KEEP'})) {
> +       @preserved_kconfigs = split(/:/,$ENV{LMC_KEEP});
> +}
>
>  sub in_preserved_kconfigs {
>      my $kconfig = $config2kfile{$_[0]};
>


-- 
Best Regards
Masahiro Yamada