Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 6/7] arm64: dts: ti: k3-*: Use generic adc for node names
To:     Nishanth Menon <nm@ti.com>, Rob Herring <robh+dt@kernel.org>,
        Tero Kristo <t-kristo@ti.com>
CC:     <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Vignesh Raghavendra <vigneshr@ti.com>, <lokeshvutla@ti.com>,
        <grygorii.strashko@ti.com>, <nsekhar@ti.com>
References: <20200901223059.14801-1-nm@ti.com>
 <20200901223059.14801-7-nm@ti.com>
From:   Suman Anna <s-anna@ti.com>
Message-ID: <60e6b790-360a-6eaf-03a3-5bb256adf215@ti.com>
Date:   Wed, 2 Sep 2020 11:51:03 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200901223059.14801-7-nm@ti.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/1/20 5:30 PM, Nishanth Menon wrote:
> Use adc@ naming for nodes following standard conventions of device
> tree (section 2.2.2 Generic Names recommendation in [1]).
> 
> [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> 
> Suggested-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>  arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi         | 4 ++--
>  arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> index 51ca4b4d4c21..6dfec68ac865 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-mcu.dtsi
> @@ -80,7 +80,7 @@
>  		#size-cells = <0>;
>  	};
>  
> -	tscadc0: tscadc@40200000 {
> +	tscadc0: adc@40200000 {

OK with these changes, since these seem to be only have the adc child nodes.
This node is essentially a parent node for touchscreen and adc child nodes. The
driver is currently looking for "tsc" on touchscreen child nodes, but none of
the K3 SoCs have them atm.

regards
Suman

>  		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
>  		reg = <0x0 0x40200000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 580 IRQ_TYPE_LEVEL_HIGH>;
> @@ -98,7 +98,7 @@
>  		};
>  	};
>  
> -	tscadc1: tscadc@40210000 {
> +	tscadc1: adc@40210000 {
>  		compatible = "ti,am654-tscadc", "ti,am3359-tscadc";
>  		reg = <0x0 0x40210000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 581 IRQ_TYPE_LEVEL_HIGH>;
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> index 9ad0266598ad..81801f519a61 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-mcu-wakeup.dtsi
> @@ -211,7 +211,7 @@
>  		};
>  	};
>  
> -	tscadc0: tscadc@40200000 {
> +	tscadc0: adc@40200000 {
>  		compatible = "ti,am3359-tscadc";
>  		reg = <0x0 0x40200000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 860 IRQ_TYPE_LEVEL_HIGH>;
> @@ -230,7 +230,7 @@
>  		};
>  	};
>  
> -	tscadc1: tscadc@40210000 {
> +	tscadc1: adc@40210000 {
>  		compatible = "ti,am3359-tscadc";
>  		reg = <0x0 0x40210000 0x0 0x1000>;
>  		interrupts = <GIC_SPI 861 IRQ_TYPE_LEVEL_HIGH>;
>