Date: Fri, 26 May 2006 10:38:21 -0700
From: Andrew Morton <akpm@osdl.org>
To: Wu Fengguang <wfg@mail.ustc.edu.cn>
Cc: linux-kernel@vger.kernel.org, wfg@mail.ustc.edu.cn, bart@samwel.tk
Subject: Re: [PATCH 27/33] readahead: laptop mode
Message-Id: <20060526103821.45329b4b.akpm@osdl.org>
In-Reply-To: <348469549.18212@ustc.edu.cn>
References: <20060524111246.420010595@localhost.localdomain>
	<348469549.18212@ustc.edu.cn>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1294
Lines: 42

Wu Fengguang <wfg@mail.ustc.edu.cn> wrote:
>
>   /*
>  + * Set a new look-ahead mark at @new_index.
>  + * Return 0 if the new mark is successfully set.
>  + */
>  +static inline int renew_lookahead(struct address_space *mapping,
>  +				struct file_ra_state *ra,
>  +				pgoff_t index, pgoff_t new_index)
>  +{
>  +	struct page *page;
>  +
>  +	if (index == ra->lookahead_index &&
>  +			new_index >= ra->readahead_index)
>  +		return 1;
>  +
>  +	page = find_page(mapping, new_index);
>  +	if (!page)
>  +		return 1;
>  +
>  +	__SetPageReadahead(page);
>  +	if (ra->lookahead_index == index)
>  +		ra->lookahead_index = new_index;
>  +
>  +	return 0;
>  +}
>  +

This is a pagecache page and other CPUs can look it up and play with it. 
The __SetPageReadahead() is quite wrong here.

And we don't have a reference on this page, so this code appears to be racy.

You could fix that by taking and dropping a ref on the page, but it'd be
quicker to take tree_lock and do the SetPageReadahead() while holding it.

This function is too large to inline.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/