Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp644293pxk; Wed, 2 Sep 2020 10:56:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGoNB9I58u5ybEsv/bxaJ1hRaFNryF3JHDOTkJyokR950IG7GyI4alLaJBmy4gkxSgyGFo X-Received: by 2002:a17:906:19db:: with SMTP id h27mr1179005ejd.154.1599069368336; Wed, 02 Sep 2020 10:56:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599069368; cv=none; d=google.com; s=arc-20160816; b=Z3dXYj1JSApcm4eW63RX+o5ZU3+bbzVvRA+tI4HkA5xyMuJ/KWZbvyQFVmk+98u0Dx evISzDVuO42Ibq/Tj4WgMt7n9Ywhh3lPfaDs5xoW+zqsZrMLP6q8knHgNrAcR2RukcO4 VqfYlhF5KSdKdafnQ508ygGssQSfn/Qla7hcEya4DROircAuF3U18oIZXPzIg8pNcnbr dp2jg/Eq14gdKogYd93Lb5EeaETX4aDTUKop7lt9MJJfAlrbxD1yn/AKfuSngciizmSN URy9G2carGbTrFcze6dS3pe/67qejfrQCz7DGYplR82wgcS+Z4V1bHF1esWLy2337YZr KnHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=2c5F6S3X96hyhdqG4dHZ2yS+M0WB1TvN9cfvaXXm7WQ=; b=y6T8bBlwWG+qqhdLuNTyb9zMLjF6Qnw2WTZjLWXykt2cLBS4n0FyK7C4vG/9lZQAlg o5aG+qU0/YOQkyQxbmT3EmH6tF07HJ4JHWU2lbJ4HqLwpVw1JiNsNvRWkLVFI5pbi1jB hADzX3goHKxi2Th4gT9Y3JOgsYj4ASodSWfM3W7xu6LwcD3cRVuWz+3SvTFjM/IFHRRX kiXpwCNYxSyhdI2W+NLIIR8RUTEwXN1vgzOYJu1rp1dL7QOhyzdKHkoVCQ6ddbD7rF8r f2GFZ8fYoi2l1unaTfYNwBvEVXt8N8X0VqS6CMY89sY2XW8BOuVoxdwgzbl2JCHs64QM CMUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XE7hzgI4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jp27si138303ejb.668.2020.09.02.10.55.45; Wed, 02 Sep 2020 10:56:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=XE7hzgI4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727867AbgIBRyA (ORCPT + 99 others); Wed, 2 Sep 2020 13:54:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726247AbgIBRx7 (ORCPT ); Wed, 2 Sep 2020 13:53:59 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D2B1C061244; Wed, 2 Sep 2020 10:53:59 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id mm21so166262pjb.4; Wed, 02 Sep 2020 10:53:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2c5F6S3X96hyhdqG4dHZ2yS+M0WB1TvN9cfvaXXm7WQ=; b=XE7hzgI4u1UxO+RUCpIrm6WyqeFvJIAkd0NMJhMPvnZLkcTZb8I+PNOiNWqNkUVarF QyXEOdtLRlGW5uLGCkz2+2k5A5snx3aMphGS4OnwnJCpuXJPIU8/ZFvcJWcPkiG9LICu V3ICoo08udx/Lx3gNL/P7lEBKSPMKbrDeNfk9d3xbwYxIA+3b98i/4r1oPAMzK8BUiIr 5qTzjz925QvMYWl2UxTs8P/D+pbKmN6qVQSMC47SV45nN+pAbwxm/7bfn+CEsTlr1ePE SEHbeM5iZgAvQMtqzb5vzBA1sfGo+eWD1Qg3n2AXA4+nbriwMMxlJinovKnlN9exeoQy L67w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2c5F6S3X96hyhdqG4dHZ2yS+M0WB1TvN9cfvaXXm7WQ=; b=QEjvpr/rP4hbPmN7dnDdNrHw7JwyOk5zsXbOYXi30Ij8GqUdAOnguYtcn0Z/AqZcdL 5JxmSuwJr995Hb2Cdw+tT2qlNmNnHCvwwwGgkRP7YO5tmfXSm6oM+4HFbZRZmZDr6o5D WWRegG/iuN/HDPRd2ENph4gP/RIZ/RywbGfYoK//6dWvd3sSzAQkSozehQAhZWMOmw9Z c4iHqzbWboVCPi6C67YxLejPmY2lX6UeiGnOxVMftpcN6Lstp2j2Cj4VBN34CqUptuMY bkmzeZdlwsTIVt+jOWMLYIAao1Prreu6BRcaKsakPBBtTUKrhGpZMnvvA5WEBdLOwuYW fvgA== X-Gm-Message-State: AOAM532H1K/LZvEzyHegzMMMZ5XkD9UtDU8uQHINOB36lc6rew2MZW7p EmXFJ874bYuSlLwHeeD/Sr0XVEzLoiA= X-Received: by 2002:a17:90b:364c:: with SMTP id nh12mr3090546pjb.182.1599069238388; Wed, 02 Sep 2020 10:53:58 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j19sm151578pfi.51.2020.09.02.10.53.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Sep 2020 10:53:57 -0700 (PDT) Subject: Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate_flow() To: Denis Efremov , Doug Berger Cc: Florian Fainelli , "David S. Miller" , Jakub Kicinski , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20200902111845.9915-1-efremov@linux.com> From: Florian Fainelli Message-ID: <34fb3dbf-9715-967a-1151-0b096327c97b@gmail.com> Date: Wed, 2 Sep 2020 10:53:54 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.1.1 MIME-Version: 1.0 In-Reply-To: <20200902111845.9915-1-efremov@linux.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/2/2020 4:18 AM, Denis Efremov wrote: > VALIDATE_MASK(eth_mask->h_source) is checked twice in a row in > bcmgenet_validate_flow(). Add VALIDATE_MASK(eth_mask->h_dest) > instead. > > Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") > Cc: stable@vger.kernel.org > Signed-off-by: Denis Efremov Acked-by: Florian Fainelli -- Florian