Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 2 Sep 2020 13:21:30 -0500
From:   Nishanth Menon <nm@ti.com>
To:     Suman Anna <s-anna@ti.com>
CC:     Rob Herring <robh+dt@kernel.org>, Tero Kristo <t-kristo@ti.com>,
        <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Vignesh Raghavendra <vigneshr@ti.com>, <lokeshvutla@ti.com>,
        <grygorii.strashko@ti.com>, <nsekhar@ti.com>
Subject: Re: [PATCH 2/7] arm64: dts: ti: k3-am65*: Use generic clock for
 serdes clock name
Message-ID: <20200902182130.r3etp3fo4lclsdl4@akan>
References: <20200901223059.14801-1-nm@ti.com>
 <20200901223059.14801-3-nm@ti.com>
 <762671ff-d78a-95aa-2817-62d3ebed104e@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <762671ff-d78a-95aa-2817-62d3ebed104e@ti.com>
User-Agent: NeoMutt/20171215
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12:45-20200902, Suman Anna wrote:
> On 9/1/20 5:30 PM, Nishanth Menon wrote:
> > Use clock@ naming for nodes following standard conventions of device
> > tree (section 2.2.2 Generic Names recommendation in [1]).
> > 
> > [1] https://github.com/devicetree-org/devicetree-specification/tree/v0.3
> > 
> > Suggested-by: Suman Anna <s-anna@ti.com>
> > Signed-off-by: Nishanth Menon <nm@ti.com>
> 
> Acked-by: Suman Anna <s-anna@ti.com>
> 
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > index 336d09d6fec7..03e28fc256de 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi
> > @@ -327,12 +327,12 @@
> >  			reg = <0x00000210 0x4>;
> >  		};
> >  
> > -		serdes0_clk: serdes_clk@4080 {
> > +		serdes0_clk: clock@4080 {
> >  			compatible = "syscon";
> >  			reg = <0x00004080 0x4>;
> >  		};
> >  
> > -		serdes1_clk: serdes_clk@4090 {
> > +		serdes1_clk: clock@4090 {
> >  			compatible = "syscon";
> >  			reg = <0x00004090 0x4>;
> >  		};
> > 
> 
> Btw, there is also ehrpwm_tbclk alongside these nodes which is currently defined
> as a syscon, but is actually a clock.

aah, good catch.. I can fix that in the follow on V2.

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D