Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp11317pxk; Wed, 2 Sep 2020 12:56:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUuG/WjtSskelNQFZ0YOeaNJhDbf056jxwVbwhhdL/11HRxWzNzl0y3DlpVNiQrulnSInS X-Received: by 2002:aa7:d593:: with SMTP id r19mr1747420edq.331.1599076586132; Wed, 02 Sep 2020 12:56:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599076586; cv=none; d=google.com; s=arc-20160816; b=ciufA4deXRdnPM4NDTPWgA39wlQPqtHzG4Bq1FZBGLTnd5saiQK/vvICVWXyaUQcT2 Lay3dFo4CO5YfE3jxT73IsDvMB5Gow8B4bjJcvG2WClXb2BZEYG+iXX6woy7vGV7+IxD zKzVMNqHz9EViWcfAfovfi9y8tq8zlZHD3co9maVNYxP9VsO89x8arf/2dgiQ+Dm82HM 58rIgBnwu5YXCaWoc9zOact0UhxOihCzd54emM3/L/ui8QkOX3eor+rPW5irg8WALsPW 89rU5spt+xmC5WDSU6+OQ/Zx5qwd1UQVOmEqTvqG1OCw4dvH5pUwiCpVom7HZb6EaX0Z vxbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=Yi7/pKhp0Q+kT0PZaK0Ayajgrr5dYJmQ3SyxnQACmW0=; b=ohnhxIg2iz6su1uqk8BBnH5+QubWjvYgRuQ1UGZL/V9H3RfEw8pwhsGPWwoXwWvgEj cuh/7VWF31UfdWXJIhGzZjAyPlcBwP7KEsKwFGJSbRzFACSbG+b2HJbw2IAc9J+gsDjj rLwprsHPzvOIea5SsMyAOzXvkrlOE8J5HDnut0v3mRN2KNRZMbWVbZFa1WrgyWxTdQ9u BtJSwGQ5/GcaYPXaVETOyLZIqnXMBfiNcl0AqDQckJi6NKYe10OBAJabOox81XpFDi0d lpSVkODPXKTA+MXjVSVeBQFz0VQKe0wt9I6fjvtUiVGEP2JxlE/SMOOdDvbf23HtOaBV 9CfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qt7si340529ejb.694.2020.09.02.12.55.39; Wed, 02 Sep 2020 12:56:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbgIBTy7 (ORCPT + 99 others); Wed, 2 Sep 2020 15:54:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726285AbgIBTy7 (ORCPT ); Wed, 2 Sep 2020 15:54:59 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3AAD3C061244; Wed, 2 Sep 2020 12:54:59 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A041D15634E01; Wed, 2 Sep 2020 12:38:11 -0700 (PDT) Date: Wed, 02 Sep 2020 12:54:57 -0700 (PDT) Message-Id: <20200902.125457.278933270676031062.davem@davemloft.net> To: efremov@linux.com Cc: opendmb@gmail.com, f.fainelli@gmail.com, kuba@kernel.org, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] net: bcmgenet: fix mask check in bcmgenet_validate_flow() From: David Miller In-Reply-To: <20200902111845.9915-1-efremov@linux.com> References: <20200902111845.9915-1-efremov@linux.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [2620:137:e000::1:9]); Wed, 02 Sep 2020 12:38:12 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Denis Efremov Date: Wed, 2 Sep 2020 14:18:45 +0300 > VALIDATE_MASK(eth_mask->h_source) is checked twice in a row in > bcmgenet_validate_flow(). Add VALIDATE_MASK(eth_mask->h_dest) > instead. > > Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") > Cc: stable@vger.kernel.org > Signed-off-by: Denis Efremov Please do not CC: stable for networking patches. Applied and queued up for -stable, thank you.