Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp37658pxk; Wed, 2 Sep 2020 13:43:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsu2lpniH0hj+TBpjSX3Mq+I7C501BIqX+H23KQBdo+pmVH+GZRYBJ5siXvSGktO4RdQRm X-Received: by 2002:a17:907:2168:: with SMTP id rl8mr1890245ejb.308.1599079435829; Wed, 02 Sep 2020 13:43:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599079435; cv=none; d=google.com; s=arc-20160816; b=gR2duXMbngbcv7h2W7FHUqx1CmooJnvvtBi41WqX0qfeSbX6dlQCz2SDRaxDNmn6wY GbVRtctuafSsDdX6X0v2GGYzeh68mVYQBVew4ctrSUiSY5nvq6gIo8gdo+iJI1NYajom N3kmFefkDCuWzpNQYopqbNOFkbv19wS2qlKonBdtPDtWVKxm9hNZrRP5t4hqRS7yjCJK m+zAoEt+BsBHfr3A8M7w9DPeNMrjijQjxFoX+SOBjzU46HQlXzJJiBwd+o9J+j4PLBdz qr8q6p15qYhFgwfht6dj69oss6A5McjREJnBM8vC3P0ChwzXXBftYcmGBoF8nLE22ELk U8wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dmarc-filter:dkim-signature; bh=ZR7O+zlwzjrNxHhPuCpyTWPmkdSYakmavLsBES19fSU=; b=P4TgumT+S9ReRIHhNGl8cEXxVBwqiySLdwGaU20SdPuhPPxf7myTmc/ze4qq4lStNF 9s11+bCG+3aPDLZ3FtMq79ur49OTztjzqZ5xDCUaBuTBC1vyPZ7hPjGwI7YjW5D86xUG JfHbky/WNgOjWfHYBrEHNRyvqRsKBR+WISPxM9e9JVT3LGJdK3qTH0Q3aIY392qG84jI +eLngM7oxsM6Sh4BwG+aJ1tFyyxyp22wYtO4NY5nXBiU/NtzPgg6WwQuqozFO/gRkL20 AQftUSRxcdjomdukaj+ey1+i27AvyxjrP6Kc4TYk1qQwe3z2FGnlRvufmL3ZuXH1Tton GVDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=qPajwzda; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si259060edc.224.2020.09.02.13.43.31; Wed, 02 Sep 2020 13:43:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=qPajwzda; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726722AbgIBUlY (ORCPT + 99 others); Wed, 2 Sep 2020 16:41:24 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:23406 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726226AbgIBUlX (ORCPT ); Wed, 2 Sep 2020 16:41:23 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1599079282; h=In-Reply-To: Content-Type: MIME-Version: References: Message-ID: Subject: Cc: To: From: Date: Sender; bh=ZR7O+zlwzjrNxHhPuCpyTWPmkdSYakmavLsBES19fSU=; b=qPajwzdac21hfC6+cZ+g8RxFqyJnOPI5fBpgmoW1h2Sb1fwyX30WU7/QhshFmitOyq7MEWEi kEnSQ7VwxkOr7x3RP9LENcrzPHZGz92GJr5J6+ONV+GTUS0EXAqCE/6fi94TyO8oeUGL/Hdf 68OcLVeOsBxdn3ZogLSiuaZSx9E= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 5f500372380a624e4daf95ea (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 02 Sep 2020 20:41:22 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id EA5CAC433AD; Wed, 2 Sep 2020 20:41:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from jcrouse1-lnx.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jcrouse) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4A0BAC43391; Wed, 2 Sep 2020 20:41:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4A0BAC43391 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=jcrouse@codeaurora.org Date: Wed, 2 Sep 2020 14:41:16 -0600 From: Jordan Crouse To: Rob Clark Cc: dri-devel@lists.freedesktop.org, Rob Clark , "open list:DRM DRIVER FOR MSM ADRENO GPU" , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , Daniel Vetter , Sean Paul Subject: Re: [Freedreno] [PATCH 2/3] drm/msm: Convert shrinker msgs to tracepoints Message-ID: <20200902204115.GB22040@jcrouse1-lnx.qualcomm.com> Mail-Followup-To: Rob Clark , dri-devel@lists.freedesktop.org, Rob Clark , "open list:DRM DRIVER FOR MSM ADRENO GPU" , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , Daniel Vetter , Sean Paul References: <20200901154200.2451899-1-robdclark@gmail.com> <20200901154200.2451899-3-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200901154200.2451899-3-robdclark@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 01, 2020 at 08:41:55AM -0700, Rob Clark wrote: > From: Rob Clark > > This reduces the spam in dmesg when we start hitting the shrinker, and > replaces it with something we can put on a timeline while profiling or > debugging system issues. Reviewed-by: Jordan Crouse > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/msm_gem_shrinker.c | 5 +++-- > drivers/gpu/drm/msm/msm_gpu_trace.h | 26 ++++++++++++++++++++++++++ > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_gem_shrinker.c b/drivers/gpu/drm/msm/msm_gem_shrinker.c > index 722d61668a97..482576d7a39a 100644 > --- a/drivers/gpu/drm/msm/msm_gem_shrinker.c > +++ b/drivers/gpu/drm/msm/msm_gem_shrinker.c > @@ -6,6 +6,7 @@ > > #include "msm_drv.h" > #include "msm_gem.h" > +#include "msm_gpu_trace.h" > > static bool msm_gem_shrinker_lock(struct drm_device *dev, bool *unlock) > { > @@ -87,7 +88,7 @@ msm_gem_shrinker_scan(struct shrinker *shrinker, struct shrink_control *sc) > mutex_unlock(&dev->struct_mutex); > > if (freed > 0) > - pr_info_ratelimited("Purging %lu bytes\n", freed << PAGE_SHIFT); > + trace_msm_gem_purge(freed << PAGE_SHIFT); > > return freed; > } > @@ -123,7 +124,7 @@ msm_gem_shrinker_vmap(struct notifier_block *nb, unsigned long event, void *ptr) > *(unsigned long *)ptr += unmapped; > > if (unmapped > 0) > - pr_info_ratelimited("Purging %u vmaps\n", unmapped); > + trace_msm_gem_purge_vmaps(unmapped); > > return NOTIFY_DONE; > } > diff --git a/drivers/gpu/drm/msm/msm_gpu_trace.h b/drivers/gpu/drm/msm/msm_gpu_trace.h > index 07572ab179fa..1079fe551279 100644 > --- a/drivers/gpu/drm/msm/msm_gpu_trace.h > +++ b/drivers/gpu/drm/msm/msm_gpu_trace.h > @@ -114,6 +114,32 @@ TRACE_EVENT(msm_gmu_freq_change, > TP_printk("freq=%u, perf_index=%u", __entry->freq, __entry->perf_index) > ); > > + > +TRACE_EVENT(msm_gem_purge, > + TP_PROTO(u32 bytes), > + TP_ARGS(bytes), > + TP_STRUCT__entry( > + __field(u32, bytes) > + ), > + TP_fast_assign( > + __entry->bytes = bytes; > + ), > + TP_printk("Purging %u bytes", __entry->bytes) > +); > + > + > +TRACE_EVENT(msm_gem_purge_vmaps, > + TP_PROTO(u32 unmapped), > + TP_ARGS(unmapped), > + TP_STRUCT__entry( > + __field(u32, unmapped) > + ), > + TP_fast_assign( > + __entry->unmapped = unmapped; > + ), > + TP_printk("Purging %u vmaps", __entry->unmapped) > +); > + > #endif > > #undef TRACE_INCLUDE_PATH > -- > 2.26.2 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno -- The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project