Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp66650pxk; Wed, 2 Sep 2020 14:40:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxKWWpgrMXgWsd0TCecxUtzIlOjM1AcQFlQk7r8ZOnn6bnU8MHnBGnXgtH1PzfmUU8eC2PA X-Received: by 2002:a17:906:924d:: with SMTP id c13mr138769ejx.518.1599082858825; Wed, 02 Sep 2020 14:40:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599082858; cv=none; d=google.com; s=arc-20160816; b=SKt5aFkK1OsjnEou9kK4axDkWdmefiZrVDe8vZdfaWynDIZed/GeBEi/N8T1mSZmGk o2d1mF/4Y+IZPHcKfZNzCAZf+v9TGHkRRaurdF2VMsrOTe8NLCgzao9GfJtOWsPDm9Yy Xl78P89NnaUton52b/Dgoa1lBE9gOv7bi9911oRHyEgdb85+wmB9NWuH8TuQY94T+oXj movoYP+n6EWEuuCkKubx8+0DiObGifeo74y8TfB8vVNYY8BUf7IkwyPXuaRXPJIaN4xK WMQscFtevamxhQktd7mYBfcnDXeS80TB/Iwy1X/IZ2xn+/gWfeoakAmiGFaA8+4urWL1 5WPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:ironport-sdr:ironport-sdr; bh=X50/VZs42fK2NOuFcku3+ecslhGXnSc4RrLXD1pBnq8=; b=EOwL6/VK3Op4fcJ5KF8hHFQfgwGIdlmG9MXy9YRcN1C2FCeh0sLewjUCxhsAcW9mJY XCrHhpBimZlNgxeBudyaeaYFC0B+FwMJPm5E7Qp+n5W1FjuJCmNwHYhla8q6obVlJkK5 k2O16c+U5i1p432Uy5ErSNz27ZCcmCCKpby8+EXLwn+Ch+NCowcqOcR0FZnag6G+rXlA cQyJjzGR9itz8Cbp2D9BDgqb9pqpkFtLCnTwqjvpD1+K4YW47dz19JzRhevxl4Kv9bBn fAk5RbTl3f7hH75oKeBLb8x7rw1ZFunLf7n4yCqFg+0Na9sYVm+ozgPpiLuzfRo6hhqP RyHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q26si521182eji.610.2020.09.02.14.40.35; Wed, 02 Sep 2020 14:40:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726377AbgIBVi7 (ORCPT + 99 others); Wed, 2 Sep 2020 17:38:59 -0400 Received: from mga01.intel.com ([192.55.52.88]:39501 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726226AbgIBVi6 (ORCPT ); Wed, 2 Sep 2020 17:38:58 -0400 IronPort-SDR: JVUR8B9IP/ddXmEt2fVDvZVAJW4J6LZjT48j0iPG5E/+Koi+7cZmReKIJSYAh7zJXPcb2AQgfZ k/Ni08lr9kNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="175532335" X-IronPort-AV: E=Sophos;i="5.76,384,1592895600"; d="scan'208";a="175532335" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 14:38:58 -0700 IronPort-SDR: R74Gpyyhve4xHettzn6a1t0Z9R83rkUlGOsa8XP8RCEr0J7K3iV8D7cgW5oHmkIDB3GkrFpHyl dpTz1U/zB2/g== X-IronPort-AV: E=Sophos;i="5.76,384,1592895600"; d="scan'208";a="325946433" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2020 14:38:58 -0700 Date: Wed, 2 Sep 2020 14:46:04 -0700 From: Jacob Pan To: Randy Dunlap Cc: Jean-Philippe Brucker , Jacob Pan , "Tian, Kevin" , Raj Ashok , Jean-Philippe Brucker , LKML , iommu@lists.linux-foundation.org, Wu Hao , David Woodhouse , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v2 3/9] iommu/ioasid: Introduce ioasid_set APIs Message-ID: <20200902144604.33595c0d@jacob-builder> In-Reply-To: References: <1598070918-21321-1-git-send-email-jacob.jun.pan@linux.intel.com> <1598070918-21321-4-git-send-email-jacob.jun.pan@linux.intel.com> <20200824182848.GB3210689@myrica> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 24 Aug 2020 11:30:47 -0700 Randy Dunlap wrote: > On 8/24/20 11:28 AM, Jean-Philippe Brucker wrote: > >> +/** > >> + * struct ioasid_data - Meta data about ioasid > >> + * > >> + * @id: Unique ID > >> + * @users Number of active users > >> + * @state Track state of the IOASID > >> + * @set Meta data of the set this IOASID belongs to > >> + * @private Private data associated with the IOASID > >> + * @rcu For free after RCU grace period > > nit: it would be nicer to follow the struct order > > and use a ':' after each struct member name, as is done for @id: > Got it, thanks.