Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Roger Quadros <rogerq@ti.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "pawell@cadence.com" <pawell@cadence.com>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        "vigneshr@ti.com" <vigneshr@ti.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: usb: cdns,usb3: Add cdns,phyrst-a-enable
 property
Thread-Topic: [PATCH 2/3] dt-bindings: usb: cdns,usb3: Add
 cdns,phyrst-a-enable property
Thread-Index: AQHWetjF2mYsQKwgvU+3PPFGyTZfuKlL0I2AgAmTp4CAAJx0gA==
Date:   Wed, 2 Sep 2020 22:48:49 +0000
Message-ID: <20200902224829.GA11250@b29397-desktop>
References: <20200825120059.12436-1-rogerq@ti.com>
 <20200825120059.12436-3-rogerq@ti.com> <20200827111343.GB5983@b29397-desktop>
 <08a7533f-b09e-f044-64e5-d709ae220599@ti.com>
In-Reply-To: <08a7533f-b09e-f044-64e5-d709ae220599@ti.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8B379C6FED2430458D6C5B48169BE3BF@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7decf3bd-7cba-4ce5-8bb0-08d84f925b88
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Sep 2020 22:48:49.1573
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RQlc2tD8jSUoN4UEZS87vWdhc/RIGx5f5gZZ9WDHbX8YS5ju7vk0uHggamSlOiANWjonNbWNw6Q9Jp3TXBY93w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6278
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-09-02 16:28:31, Roger Quadros wrote:
> Peter,
>=20
> On 27/08/2020 14:14, Peter Chen wrote:
> > On 20-08-25 15:00:58, Roger Quadros wrote:
> > > Controller version 0x0002450D has USB2 PHY RX sensitivity issues
> > > that needs to be worked around by enabling phyrst-a-enable bit
> > > in PHYRST_CFG register.
> > >=20
> > > There is no way to distinguish between the controller version
> > > before the device controller is started so we need to add this
> > > DT property.
> >=20
> > Maybe you should say "There is no way to know controller version
> > at host mode, but this workaround needs for both host and device
> > mode, so we have to add this DT property", the same for the comments
> > of your driver code patch.
>=20
> I will reword it to
>=20
> "There is no way to know controller version before device controller
> is started and the workaround needs to be applied for both host and
> device modes, so we add this DT property"
>=20

After apply it, feel free add:

Reviewed-by: Peter Chen <peter.chen@nxp.com>

Please apply above for device party commit log as well.

--=20

Thanks,
Peter Chen=