Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <71837114676678d44500f146a2d98bbe9e541c65.camel@perches.com>
Subject: Re: [PATCH v2] use cpu_to_le{16,32} instead of __constant_cpu_to_*
From:   Joe Perches <joe@perches.com>
To:     Rene Rebe <rene@exactcode.com>, linux-kernel@vger.kernel.org
Cc:     Arnd Bergmann <arnd@arndb.de>, himanshu.madhani@oracle.com
Date:   Wed, 02 Sep 2020 18:58:59 -0700
In-Reply-To: <20200902.232949.1343752343092794969.rene@exactcode.com>
References: <b7719680-e451-5687-1fb7-c8c059a880d4@acm.org>
         <2C755628-1426-4BA4-B2A3-AD059BB0F605@exactcode.com>
         <c7daea00-410d-2073-bf52-2abda9acdf8e@acm.org>
         <20200902.232949.1343752343092794969.rene@exactcode.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 2020-09-02 at 23:29 +0200, Rene Rebe wrote:
> As per recommendation, convert a few remaining __constant_cpu_to_le{16,32}
> instances in the qla2xxx, qla4xxx and cifs to just cpu_to_le{16,32}.
[]
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
[]
> @@ -3583,7 +3583,7 @@ static int __qlt_send_term_imm_notif(struct scsi_qla_host *vha,
>  
>         /* terminate */
>         nack->u.isp24.flags |=
> -               __constant_cpu_to_le16(NOTIFY_ACK_FLAGS_TERMINATE);
> +               cpu_to_le16(NOTIFY_ACK_FLAGS_TERMINATE);

trivia: this now fits on a single line.