Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Thu, 03 Sep 2020 10:55:05 +0100
From:   Marc Zyngier <maz@kernel.org>
To:     Zou Cao <zoucao@linux.alibaba.com>
Cc:     linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, jason@lakedaemon.net
Subject: Re: [PATCH] irqchip/gic-v3: change gic_data into gic_v3_data
In-Reply-To: <1599124088-80231-1-git-send-email-zoucao@linux.alibaba.com>
References: <1599124088-80231-1-git-send-email-zoucao@linux.alibaba.com>
User-Agent: Roundcube Webmail/1.4.8
Message-ID: <c6eacce9e0990239ee12bfc5826fe2c6@kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-09-03 10:08, Zou Cao wrote:
> There are multiple gic_data symbol between irq_gic.c and irq_gic_v3.c,
> we can see the same symbol name:
> 
> 	cat /proc/kallsyms | grep gic_data
> ------>
> 	ffff80001138f1d0 d gic_data
> 	ffff80001138f940 d gic_data
> 
> Normally CONFIG_ARM_GIC and CONFIG_ARM_GIC_V3 are all enabled, move
> the gic_data symbol into different name, it will be friend for
> kallsyms_lookup_name to get addr easily.
> 
> Signed-off-by: Zou Cao <zoucao@linux.alibaba.com>

I'm sorry, but this kind of change is not acceptable.

It is pure churn, for zero benefit. As an example, give the following
script a go:

awk '{ print $3 }' /proc/kallsyms | sort | uniq -c| awk '$1 > 1 
{print}'| sort -n

Are you going to repaint all these symbols?

         M.
-- 
Jazz is not dead. It just smells funny...