Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp416605pxk; Thu, 3 Sep 2020 03:15:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxg0VYmLAC2NIENyoxjageXdj9kGzwOrio0Kujg+0rhNy/B6tDBl9VBHKRUwmBWx6FXpEO4 X-Received: by 2002:a17:906:5fc5:: with SMTP id k5mr1266499ejv.63.1599128120946; Thu, 03 Sep 2020 03:15:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599128120; cv=none; d=google.com; s=arc-20160816; b=pi+nxNTI8y63njAU+CvXC1KE/ik101Ad3iQWKtBnWwcwYH4ZhZYEyeixk6ShcOKIWu KL9yM71uuCkDcsQD9vygiQNJBgyxaXaLF1YF1Pt9jW6YLa0Ao96UU9Ku/0iBRkTEfAhj oP+XplFtjiRajkXr+xZTl6Rzxw+jISm8e9SzLJ/agi+W1l+rBtfox1ib2S7yvZfOwnee BxnsY+uYx6Z/fxDbgTEiWsir+kUPiGlOousUdcZUakpqOf1dhSQ5SPIICp8wUFRKVdr7 vYR972+qtB0A8czyeH9BnKCNfqk5Rf+bK/8YugSqfEj21E6xUuq7S47eQymoYDCwN+gj G2RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=iQkEBCh6iKMpQpgfdrRHvzhs75hFwZH+hQzfwUWM7II=; b=cD+yxAJ6m1bLH4j88Ac81/vzHFcS+eZb5pBYQle7Ue6/9r5MqIIikAr54/clYraGhN 16K5iXWkMl3EOr9qchB2PLKQG9IBEuxo/FeR4m04uNo0wxP84pGNQD/kzkL1qoXPJ4JB xQnI9HowaQOtnPxKkm3/kjZURWNWRLQTeGEkwL8xfvvHsKwrEgpx81zaHIImoODQu5Vf AHsQQ6uh8KhS05ZspwDLwtSDGJbbFKrSTnhbzvJybkWFdH9TiFaUDLJ0rFuAsUSeFx+s WtR7p303mwIdBiWg20LoECHWjRnUEQhMTEc74zGVuSa8avLDN6GBqVxYnAJ2B1KiE6c9 ZnzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zWPwcuSw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l91si1284566ede.242.2020.09.03.03.14.56; Thu, 03 Sep 2020 03:15:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zWPwcuSw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726537AbgICKMT (ORCPT + 99 others); Thu, 3 Sep 2020 06:12:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:56736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgICKMR (ORCPT ); Thu, 3 Sep 2020 06:12:17 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0B5F20767; Thu, 3 Sep 2020 10:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599127936; bh=2F8Sftn0TzNaRjueUQEfuF/9mW8ur/5mCYKJYptfj+w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zWPwcuSwHqTM741dmhtXPm6Fk9sZgDiLLVtQgGjxAPWAfenaMD8jwEd5pzMqv0W0a wUaY76eeG4NWRdhWYBn1R2i7rGINVA6O9PzF1coba7hHEXc8hwkjRMbJs6furkST0U aS6iNbP9PGqr/yL1tCBL7D55MhUTyc7DaVrPji/k= Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kDmE2-008rL1-U8; Thu, 03 Sep 2020 11:12:15 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Thu, 03 Sep 2020 11:12:14 +0100 From: Marc Zyngier To: zc Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net Subject: Re: [PATCH] irqchip/gic-v3: change gic_data into gic_v3_data In-Reply-To: <69118106-e6d8-71dc-7004-80fd96b32e54@linux.alibaba.com> References: <1599124088-80231-1-git-send-email-zoucao@linux.alibaba.com> <69118106-e6d8-71dc-7004-80fd96b32e54@linux.alibaba.com> User-Agent: Roundcube Webmail/1.4.8 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: zoucao@linux.alibaba.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, jason@lakedaemon.net X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-03 11:05, zc wrote: >   thank for you reply. > > >    of course it won't,   i just think it is better to splite the > global data between irq-gic and irq-gic-v3. > > I wrote some hook module for gic,  kallsyms_lookup_name can't support > for mutlipte symbol, > > i need to call kallsyms scan to get the addr. Why would you need to hook into the GIC data? >   If you think it isn't necessary, well for me. I don't think it is necessary for mainline to work correctly, and I don't understand what you are trying to achieve with this "hook module". If you could explain what you are trying to do and why you are doing it, maybe we can come up with something. But I don't think blindly repainting symbol names is a sensible course of action. Thanks, M. -- Jazz is not dead. It just smells funny...