Date: Fri, 26 May 2006 16:10:44 -0700
From: Rajesh Shah <rajesh.shah@intel.com>
To: Brice Goglin <brice@myri.com>
Cc: Andrew Morton <akpm@osdl.org>, Shaohua Li <shaohua.li@intel.com>,
       linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org,
       greg@kroah.com, tom.l.nguyen@intel.com, rajesh.shah@intel.com
Subject: Re: [RFC]disable msi mode in pci_disable_device
Message-ID: <20060526161043.A16912@unix-os.sc.intel.com>
Reply-To: Rajesh Shah <rajesh.shah@intel.com>
References: <1148612307.32046.132.camel@sli10-desk.sh.intel.com> <20060526125440.0897aef5.akpm@osdl.org> <44776491.1080506@myri.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <44776491.1080506@myri.com>; from brice@myri.com on Fri, May 26, 2006 at 10:26:57PM +0200
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 709
Lines: 17

On Fri, May 26, 2006 at 10:26:57PM +0200, Brice Goglin wrote:
> 
> I just tried, the patch fixes our problem (no need to restore right
> after saving to reenable MSI).
> 
Yeah, I agree this latest patch from Shaohua is the right thing,
and that pci save/restore msi state functions should not have
the side effect of disabling/enabling MSI. Shaohua, do drivers
already call pci_disable_device() or will you have to patch
them all to get the disable effect?

Rajesh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/