Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Sep 2020 14:22:41 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: spi-imx: correct interpretation of num-cs DT property?
Message-ID: <20200903132241.GB4771@sirena.org.uk>
References: <ecfa135b7b83a31bed821ec0740ab3cf1d39da15.camel@ew.tq-group.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="ADZbWkCsHQ7r3kzd"
Content-Disposition: inline
In-Reply-To: <ecfa135b7b83a31bed821ec0740ab3cf1d39da15.camel@ew.tq-group.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ADZbWkCsHQ7r3kzd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 03, 2020 at 11:22:20AM +0200, Matthias Schiffer wrote:

> - If num-cs is set, use that
> - If num-cs is unset, use the number of cs-gpios
> - If num-cs is unset and no cs-gpios are defined, use a driver-provided=
=20
> default (which is 3 for spi-imx; this matches the number of native CS
> pins in older implementations of this SPI controller; i.MX6 and newer
> support up to 4)

That sounds like what's expected, though we coould just skip the first
step.

> Also, would it make sense to add num-cs to all DTS files for boards
> that actually use fewer than 3 CS pins?

No, it was never a good idea to have that property in the first place
and there should be no case where it helps anything.

> At the moment, the num-cs property is not explicitly documented for the
> spi-imx driver, although the driver understands it. I also suggested to
> add this to the docs, which Fabio didn't deem a good idea (I don't
> quite understand the reasoning here - isn't num-cs generally a useful
> property to have?)

Could you explain what benefit you would expect having num-cs to offer?

--ADZbWkCsHQ7r3kzd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9Q7iAACgkQJNaLcl1U
h9DI4Qf+IFmOS7dEEhxYZrT/kDf0F1Z6Kj6qTImRT4ImOPc1hhlzs6e9o2HxAj95
SfPAinxGHrl9ClrK2J8e4XG7xxu+UNfom6FGwma3oz0nhwPJ+kJx6LaQYDdEdCYc
mgK3XD+n87gwKoS4DdbZxpFTdAE2XR+ngKlDJUdhYmlWxKgGZuWzJfw4ehTZlqbg
Rvgr9CY+AT6mKFDq9dZS2AxFXpD5LLqOHj4XX25MjpWS9AdSjWuWyop24WbvF2nj
YJqrMqto0ygGJdW94+ugGz2T+82EOI6Bm17NcpYzXHcSFT7d97GCC2kQbTQmIDql
1sAVyODUHKz5reRHSSFsIebJiRJSjQ==
=CrVc
-----END PGP SIGNATURE-----

--ADZbWkCsHQ7r3kzd--