Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Sep 2020 10:35:45 -0500
From:   Josh Poimboeuf <jpoimboe@redhat.com>
To:     Kristen Carlson Accardi <kristen@linux.intel.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        linux-kernel@vger.kernel.org, Miroslav Benes <mbenes@suse.cz>
Subject: Re: [PATCH] objtool: support symtab_shndx during dump
Message-ID: <20200903153545.zy24o7pqfohgoxge@treble>
References: <20200812175712.9462-1-kristen@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200812175712.9462-1-kristen@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Aug 12, 2020 at 10:57:11AM -0700, Kristen Carlson Accardi wrote:
> When getting the symbol index number, make sure to use the
> extended symbol table information in order to support symbol
> index's greater than 64K.

"indexes"

>  			if (GELF_ST_TYPE(sym.st_info) == STT_SECTION) {
> -				scn = elf_getscn(elf, sym.st_shndx);
> +				if ((sym.st_shndx > SHN_UNDEF &&
> +				     sym.st_shndx < SHN_LORESERVE) ||
> +				    (xsymtab && sym.st_shndx == SHN_XINDEX)) {
> +					if (sym.st_shndx != SHN_XINDEX)
> +						shndx = sym.st_shndx;

The sym.st_shndx checks are redundant, if 'sym.st_shndx == SHN_XINDEX'
then 'sym.st_shndx != SHN_XINDEX' can't be true.

Actually I think this can be even further simplified to something like

				if (!shndx)
					shndx = sym.st_shndx;

-- 
Josh