Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp709464pxk;
        Thu, 3 Sep 2020 10:34:36 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJwDAOlXvRGlKdn7Rv4sn3d2VUy3x5amSEdVo+LxX1QjSUicU48rGdyWi89ApEwxCf5zHUY2
X-Received: by 2002:a17:906:fc11:: with SMTP id ov17mr3421366ejb.549.1599154476448;
        Thu, 03 Sep 2020 10:34:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1599154476; cv=none;
        d=google.com; s=arc-20160816;
        b=BVCFInhGth4kX9uX9fQLluMQn8MaIhQVpndFyHqmOg47LMZNTStw8WQkJbgCGNG87J
         C+e+rj0m2QBrvVtl4jWVJ4ygCyMlbF7I/J9Dx3c7rXiUDZcqX1PyK2Pr6X72Y42oqkI6
         siXnKvnbB/MlWxnxOHi/YAhRCgWYeRLW3xpYAoTuJEdViV/NHMVaBPfsZDAv6d/7pFha
         gu0IQNH2D9cgu1t20o1TVAh54Iyuv5c02Kgz+wwtFiwjMYNo12xoUoeE2vt/fNi6i/LV
         pzd/WVqFzYHb7jckiT0FBpChqi5Im2CP8D193A2Sn/Zp4gmXmkl2KECb/l7dk04+ofUO
         h+RA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=f2fM2vwocWZ3kjufXMQxbdqVic6XFgHZzhjDyCnkunM=;
        b=tgSJ7TPimGUB08K1oEeuYhAI1jlBx154Y6s4iaYIMnsoQClEMhKswRI9Knw8z0wRfW
         O1DbQ8X+sImi5PnyWB2sno41d2VVmaKpttvgWO6WW07yUPfVNvIZ7ptLb9mFdZgc8ueP
         KROFurxGLNrBASvJZABE+3nLUpUI97gpr/CVf+YsdUcyv4ALakjB8qD0tBpGicLg23ft
         wl53B+jmBdD3ySH7Hf1PHIrBoGBjxukR9hYRJaJ9paWASTbeXD8m4oMEc2r9iqYmfmNd
         obxeOL7oqv0zhevSL6rypVzKfvh9K9O1hfujnqo3bLt4KDJJLhzwJrb5P6u7Cj6KKvEP
         JuDA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=QNI5HP0m;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id x43si2601044ede.268.2020.09.03.10.34.11;
        Thu, 03 Sep 2020 10:34:36 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=QNI5HP0m;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728382AbgICRbr (ORCPT <rfc822;peterpeng024@gmail.com>
        + 99 others); Thu, 3 Sep 2020 13:31:47 -0400
Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:8183 "EHLO
        hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726025AbgICRbq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Sep 2020 13:31:46 -0400
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5f5128740001>; Thu, 03 Sep 2020 10:31:32 -0700
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 03 Sep 2020 10:31:46 -0700
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 03 Sep 2020 10:31:46 -0700
Received: from rcampbell-dev.nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com
 (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 3 Sep
 2020 17:31:45 +0000
Subject: Re: [PATCH 1/2] arm64/mm: Change THP helpers to comply with generic
 MM semantics
To:     Catalin Marinas <catalin.marinas@arm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>
CC:     <linux-mm@kvack.org>, <linux-arm-kernel@lists.infradead.org>,
        <will@kernel.org>, <akpm@linux-foundation.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Marc Zyngier <maz@kernel.org>,
        Suzuki Poulose <suzuki.poulose@arm.com>,
        <linux-kernel@vger.kernel.org>
References: <1597655984-15428-1-git-send-email-anshuman.khandual@arm.com>
 <1597655984-15428-2-git-send-email-anshuman.khandual@arm.com>
 <20200903165631.GC31409@gaia>
From:   Ralph Campbell <rcampbell@nvidia.com>
X-Nvconfidentiality: public
Message-ID: <5e148194-58c2-89c2-2cd8-9f2086f1e090@nvidia.com>
Date:   Thu, 3 Sep 2020 10:31:44 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20200903165631.GC31409@gaia>
X-Originating-IP: [10.124.1.5]
X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To
 HQMAIL107.nvidia.com (172.20.187.13)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1599154292; bh=f2fM2vwocWZ3kjufXMQxbdqVic6XFgHZzhjDyCnkunM=;
        h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality:
         Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:
         X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=QNI5HP0mnE11hwdtt//Zo7KAtHH9mutFkC4v29SLNtD3RB0sKvljOyjJnoPg+nCNM
         g+qnLvvVo8HmZ/lXWGqm0dCvXsip0qT67hm2Pi5MyMMb9CeerPM3SMY1oBZWFU+GLi
         iDyu+m1RiBar/mNEX68xxKokJtsOiKYauiJaX5OpW5taL58vgmY+vUh/oPN/eVXnZr
         r2yFhkOEOz1gESPASBuELH47vVnksoAmeTIpU8qRKYseB7Ky2Jj9MQZDLq/lb7VWla
         m5aCR0YsGQSuBd26pUDXoM3Ji2XbK+mMbD797bTL+BujGtVTSA4uXS6c5OA64PUjX/
         0nR2261UeRJRw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/3/20 9:56 AM, Catalin Marinas wrote:
> On Mon, Aug 17, 2020 at 02:49:43PM +0530, Anshuman Khandual wrote:
>> pmd_present() and pmd_trans_huge() are expected to behave in the following
>> manner during various phases of a given PMD. It is derived from a previous
>> detailed discussion on this topic [1] and present THP documentation [2].
>>
>> pmd_present(pmd):
>>
>> - Returns true if pmd refers to system RAM with a valid pmd_page(pmd)
>> - Returns false if pmd does not refer to system RAM - Invalid pmd_page(pmd)
> 
> The second bullet doesn't make much sense. If you have a pmd mapping of
> some I/O memory, pmd_present() still returns true (as does
> pte_present()).
> 
>> diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h
>> index 4d867c6446c4..28792fdd9627 100644
>> --- a/arch/arm64/include/asm/pgtable-prot.h
>> +++ b/arch/arm64/include/asm/pgtable-prot.h
>> @@ -19,6 +19,13 @@
>>   #define PTE_DEVMAP		(_AT(pteval_t, 1) << 57)
>>   #define PTE_PROT_NONE		(_AT(pteval_t, 1) << 58) /* only when !PTE_VALID */
>>   
>> +/*
>> + * This help indicate that the entry is present i.e pmd_page()
> 
> Nit: add another . after i.e

Another nit: "This help indicate" => "This helper indicates"

Maybe I should look at the series more. :-)