Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tools build feature: cleanup feature files on make clean
To:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc:     linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
        bpf@vger.kernel.org
References: <159851841661.1072907.13770213104521805592.stgit@firesoul>
 <20200903190350.GI3495158@kernel.org>
From:   Daniel Borkmann <daniel@iogearbox.net>
Message-ID: <eb3ad60a-68be-f350-9597-b999edae5244@iogearbox.net>
Date:   Thu, 3 Sep 2020 21:20:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <20200903190350.GI3495158@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Arnaldo,

On 9/3/20 9:03 PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 27, 2020 at 10:53:36AM +0200, Jesper Dangaard Brouer escreveu:
>> The system for "Auto-detecting system features" located under
>> tools/build/ are (currently) used by perf, libbpf and bpftool. It can
>> contain stalled feature detection files, which are not cleaned up by
>> libbpf and bpftool on make clean (side-note: perf tool is correct).
>>
>> Fix this by making the users invoke the make clean target.
>>
>> Some details about the changes. The libbpf Makefile already had a
>> clean-config target (which seems to be copy-pasted from perf), but this
>> target was not "connected" (a make dependency) to clean target. Choose
>> not to rename target as someone might be using it. Did change the output
>> from "CLEAN config" to "CLEAN feature-detect", to make it more clear
>> what happens.
> 
> Since this mostly touches BPF, should it go via the BPF tree?

Already applied roughly a week ago:

https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=661b37cd437ef49cd28444f79b9b0c71ea76e8c8

Thanks,
Daniel