Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Sep 2020 14:31:17 -0500
From:   Corey Minyard <minyard@acm.org>
To:     Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc:     arnd@arndb.de, gregkh@linuxfoundation.org,
        openipmi-developer@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ipmi: add a newline when printing parameter 'panic_op'
 by sysfs
Message-ID: <20200903193117.GB4442@minyard.net>
Reply-To: minyard@acm.org
References: <1599130873-2402-1-git-send-email-wangxiongfeng2@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1599130873-2402-1-git-send-email-wangxiongfeng2@huawei.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Sep 03, 2020 at 07:01:13PM +0800, Xiongfeng Wang wrote:
> When I cat ipmi_msghandler parameter 'panic_op' by sysfs, it displays as
> follows. It's better to add a newline for easy reading.
> 
> root@(none):/# cat /sys/module/ipmi_msghandler/parameters/panic_op
> noneroot@(none):/#

Thanks, it's in my for-next queue.

-corey

> 
> Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
> ---
>  drivers/char/ipmi/ipmi_msghandler.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
> index 737c0b6..6ebb549 100644
> --- a/drivers/char/ipmi/ipmi_msghandler.c
> +++ b/drivers/char/ipmi/ipmi_msghandler.c
> @@ -89,19 +89,19 @@ static int panic_op_read_handler(char *buffer, const struct kernel_param *kp)
>  {
>  	switch (ipmi_send_panic_event) {
>  	case IPMI_SEND_PANIC_EVENT_NONE:
> -		strcpy(buffer, "none");
> +		strcpy(buffer, "none\n");
>  		break;
>  
>  	case IPMI_SEND_PANIC_EVENT:
> -		strcpy(buffer, "event");
> +		strcpy(buffer, "event\n");
>  		break;
>  
>  	case IPMI_SEND_PANIC_EVENT_STRING:
> -		strcpy(buffer, "string");
> +		strcpy(buffer, "string\n");
>  		break;
>  
>  	default:
> -		strcpy(buffer, "???");
> +		strcpy(buffer, "???\n");
>  		break;
>  	}
>  
> -- 
> 1.7.12.4
>