Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Sep 2020 17:21:37 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Adrian Hunter <adrian.hunter@intel.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>
Cc:     Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
        Namhyung Kim <namhyung@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 4/6] perf tools: Add FIFO file names as alternative
 options to --control
Message-ID: <20200903202137.GO3495158@kernel.org>
References: <20200901200655.GC470123@krava>
 <20200902105707.11491-1-adrian.hunter@intel.com>
 <97818947-ed04-1b53-c71a-f00732141ca7@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <97818947-ed04-1b53-c71a-f00732141ca7@linux.intel.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Wed, Sep 02, 2020 at 08:03:08PM +0300, Alexey Budankov escreveu:
> 
> On 02.09.2020 13:57, Adrian Hunter wrote:
> > Enable the --control option to accept file names as an alternative to
> > file descriptors.
> > 
> > Example:
> > 
> >  $ mkfifo perf.control
> >  $ mkfifo perf.ack
> >  $ cat perf.ack &
> >  [1] 6808
> >  $ perf record --control fifo:perf.control,perf.ack -- sleep 300 &
> >  [2] 6810
> >  $ echo disable > perf.control
> >  $ Events disabled
> >  ack
> > 
> >  $ echo enable > perf.control
> >  $ Events enabled
> >  ack
> > 
> >  $ echo disable > perf.control
> >  $ Events disabled
> >  ack
> > 
> >  $ kill %2
> >  [ perf record: Woken up 4 times to write data ]
> >  $ [ perf record: Captured and wrote 0.018 MB perf.data (7 samples) ]
> > 
> >  [1]-  Done                    cat perf.ack
> >  [2]+  Terminated              perf record --control fifo:perf.control,perf.ack -- sleep 300
> >  $
> > 
> > Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> > Acked-by: Jiri Olsa <jolsa@redhat.com>

Its great when things come with the exact sequence of commands to
test, the output, etc, keep it that way, please.

Thanks, tested, applied,

- Arnaldo