Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 3 Sep 2020 19:04:54 -0500
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc:     linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        tsoni@codeaurora.org, psodagud@codeaurora.org,
        sidgup@codeaurora.org
Subject: Re: [PATCH v3 1/3] remoteproc: Expose remoteproc configuration
 through sysfs
Message-ID: <20200904000454.GD3715@yoga>
References: <1599174226-2307-1-git-send-email-rishabhb@codeaurora.org>
 <1599174226-2307-2-git-send-email-rishabhb@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1599174226-2307-2-git-send-email-rishabhb@codeaurora.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu 03 Sep 18:03 CDT 2020, Rishabh Bhatnagar wrote:

> Add a feature flag to expose some of the remoteproc configuration
> through sysfs. This feature is helpful in systems where debugfs is
> not available/mounted. Currently the recovery and coredump
> configuration is exposed through sysfs rather than debugfs when
> this feature is selected.
> 

This commit message gives me the feeling that it's about making a
selection between debugfs vs sysfs. But the patches moves the code from
debugfs to sysfs and then hide it behind this config option.

That said, I just commented on v2 questioning that this should be a
compile time option at all - might be useful for some drivers to
dynamically "hide" these sysfs attributes though.

Regards,
Bjorn

> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> ---
>  drivers/remoteproc/Kconfig | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index c6659dfe..98d52cbe 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -275,6 +275,17 @@ config TI_K3_DSP_REMOTEPROC
>  	  It's safe to say N here if you're not interested in utilizing
>  	  the DSP slave processors.
>  
> +config RPROC_SYSFS_CONFIGURATION_SUPPORT
> +	bool "Expose remoteproc configuration sysfs entries"
> +	default y
> +	help
> +	  Say y here to expose recovery and coredump configuration sysfs
> +	  entries. This is helpful in operating systems where debugfs is
> +	  not available/mounted.
> +
> +	  It's safe to say N here if you are not interested in accessing
> +	  recovery and coredump configuration through sysfs.
> +
>  endif # REMOTEPROC
>  
>  endmenu
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>