Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp955319pxk; Thu, 3 Sep 2020 18:00:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyheSbR0Unow1jBsQiGjLmWs1qTwj7Enjnp+23Xhj5bpLQLxkNncb3WlYlVa8A6RK3fScWe X-Received: by 2002:a17:906:841a:: with SMTP id n26mr4797880ejx.213.1599181257795; Thu, 03 Sep 2020 18:00:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599181257; cv=none; d=google.com; s=arc-20160816; b=mjffnAtCIg8+j+9Ux76cMdnnHH3OxTtFVjxisHlKHbzVMX4wQUrp6C574SDURLA63K uT4akL27uS8N4MutUuY305yYfjQKJKq+Q+s26IfQGO9QaC4mPAo2YtzsNFqzNowRyXbY q4WL72dxp9Q9a/JpqTdzGPnkiH/b/oPTft8fbeqKkuoipSYtTy2UsVixhctWvR2H6//p 7IE6hVpcubTJMv/tj143AjW66ssJ0CYdbFZ73W20SHXlj1ccj21hyWU7CTqv/6fIun6z S5fA9s38p5+HsssVrree/inpqdY6x33MKVCczahOKI2jEBKtbnXtGnbf7YsNFV1AAskM y2Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:cc:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=qvfCuz0yuh3MsTm69717RI4Gp9IbhKPEeIA+SE5rkxE=; b=Cq2aNG8UchgGgD+QdNCPYcrgv2B/7EU0kgKK7+2wnY6hhoelWT08oixj4yn88+VOdy 0+lhSBsWJMf1wuwFpGSPt1FTRFOG5lVlXfBmU97GJXGbUzcAryQ1zMfMKOJOqlZ8bzuM ZW//rXkRa5LLAVVD2BIVuvSZuvSxF998iWcayMWv2DvvzIYQzuwecICssHgGXEK0wx0q UVWgwwYy7sRazD7KN2HZdx/vqt4mKQsH4xJWBH1fnLTZhGWPsfFx5f+AzbLZizCy6bVc DJiR5TUzL8H7Ab7M5jGJxZyVoKa3yEwPdE3GHZXvqJVWgKgZb3P0eq6doKffQNYH4SN2 ndog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AQIa8Aj6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i24si2778049edr.73.2020.09.03.18.00.18; Thu, 03 Sep 2020 18:00:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AQIa8Aj6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbgIDA72 (ORCPT + 99 others); Thu, 3 Sep 2020 20:59:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728294AbgIDA71 (ORCPT ); Thu, 3 Sep 2020 20:59:27 -0400 Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D59CC061244 for ; Thu, 3 Sep 2020 17:59:27 -0700 (PDT) Received: by mail-ej1-x643.google.com with SMTP id q13so6331092ejo.9 for ; Thu, 03 Sep 2020 17:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:cc; bh=qvfCuz0yuh3MsTm69717RI4Gp9IbhKPEeIA+SE5rkxE=; b=AQIa8Aj6RUic6TSZZuyxkYyKhejkbrDibWkAqUSRozIVY7YGfnjw/4ELqOl9Eu0Ldd Hh5rJ5oWy2GFLESM2kMmZHrZvL/OU7Zcz4WG7PzAqLfGmGzwlAimgYJ1oz8r6mdGLbKU hf6Kyz8hL6ttt0dquUCFa6xj6RCcnjjy9GX4ZkK4CvAcN32d83LQ6wwyFqgiWNuUDeye kc2Jc3iCqTQ9hY1s9XJvBPgQx1Gc8Vy3abPvM86K+4y5otR3dIoCYS7planxcPeX/GiN rgRBUlYS7TivxOAzKLKr/JEJGTFcv9qW3/VMUe63c+NKqVYbFEtLrfWIBTWnSJuiJKy1 YyFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:cc; bh=qvfCuz0yuh3MsTm69717RI4Gp9IbhKPEeIA+SE5rkxE=; b=nTL6aDxOD8jBaeS2+TZHuCiLvQFNkNNLjX81u769In0aZw6jNm6d3BndxOwZh6z0oP zxdqjmgog6e1vX/DnRkvHsjGfunXtbLcVA4WBB2ont7hk/jKRVxrVBlbkTwOrMNs+BQq DxrBxRiRCk24c3KK+5386Ht48SypzbGXNX0ykeQ0n081U3kRi2Iva9DOgx/YC+pUMNIB KuWQH9BZRiemEkk+vokbvh147FOnAyAPA7Bo73SsYaJRPb7776+zdmxsvYSYUWUh46sW mLgNCMGceLB/Y0V4Kr/r4rjzpLi21n08FTD5OQFt/4i9Z+u2LgeZj7DlyAerVU84zzv9 hjiA== X-Gm-Message-State: AOAM5329Z199JCIAyfJLq0zQBYMrx2COo1ohhQvi4xd+YY9aP+eaSS0r D9KUTn8QRvPVcgiQHHBd5GrQAlp3nJnN5XArAJn5IunDFwSENysA X-Received: by 2002:a17:906:bc47:: with SMTP id s7mt4686597ejv.354.1599181165713; Thu, 03 Sep 2020 17:59:25 -0700 (PDT) MIME-Version: 1.0 References: <20200904003408.452999-1-anant.thazhemadam@gmail.com> In-Reply-To: <20200904003408.452999-1-anant.thazhemadam@gmail.com> From: Anant Thazhemadam Date: Fri, 4 Sep 2020 06:29:14 +0530 Message-ID: Subject: Re: [PATCH] Remove unused variables Cc: Ian Abbott , H Hartley Sweeten , Greg Kroah-Hartman , "Alexander A. Klimov" , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch was generated, and sent by a script I was working on (and apparently, still am), that would run sparse, detect unused variables and eliminate them. However, upon manual inspection, it became clear to me that these functions are in fact necessary. I'm sorry this mistake happened. Kindly ignore and discard this patch. My sincere apologies. Thanks, Anant On Fri, Sep 4, 2020 at 6:04 AM Anant Thazhemadam wrote: > > A few unused variables that were defined were found and removed. > > Signed-off-by: Anant Thazhemadam > --- > drivers/staging/comedi/drivers/dt2814.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dt2814.c b/drivers/staging/comedi/drivers/dt2814.c > index bcf4d5444faf..1a36d8612d9f 100644 > --- a/drivers/staging/comedi/drivers/dt2814.c > +++ b/drivers/staging/comedi/drivers/dt2814.c > @@ -190,7 +190,6 @@ static irqreturn_t dt2814_interrupt(int irq, void *d) > struct comedi_device *dev = d; > struct dt2814_private *devpriv = dev->private; > struct comedi_subdevice *s = dev->read_subdev; > - int data; > > if (!dev->attached) { > dev_err(dev->class_dev, "spurious interrupt\n"); > @@ -229,7 +228,6 @@ static int dt2814_attach(struct comedi_device *dev, struct comedi_devconfig *it) > struct dt2814_private *devpriv; > struct comedi_subdevice *s; > int ret; > - int i; > > ret = comedi_request_region(dev, it->options[0], 0x2); > if (ret) > -- > 2.25.1 >