Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: mt8173-elm: fix supported values for
 regulator-allowed-modes of da9211
To:     Dafna Hirschfeld <dafna.hirschfeld@collabora.com>,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        matthias.bgg@gmail.com, robh+dt@kernel.org
Cc:     kernel@collabora.com, dafna3@gmail.com
References: <20200903142819.24487-1-dafna.hirschfeld@collabora.com>
From:   Enric Balletbo i Serra <enric.balletbo@collabora.com>
Message-ID: <5d504bea-0934-91a9-c052-e463ad6c6d95@collabora.com>
Date:   Fri, 4 Sep 2020 10:02:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20200903142819.24487-1-dafna.hirschfeld@collabora.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Dafna,

Thank you to work on this.

On 3/9/20 16:28, Dafna Hirschfeld wrote:
> According to the datasheet the allowed modes for the da9211
> regulator are sync and auto mode. This should be changed in the
> devicetree. This also fix an error message
> 'BUCKA: invalid regulator-allowed-modes element 0'
> since value 0 is invalid.
> 
> Fixes: 689b937beddeb ("arm64: dts: mediatek: add mt8173 elm and hana board")
> Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>

Double checked the regulator supported modes and I can confirm that this patch
gets rid of the error message, so:

Tested-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
>  arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> index 1fe5dac24ba1..1a51879d5c6f 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi
> @@ -5,6 +5,7 @@
>  
>  #include <dt-bindings/input/input.h>
>  #include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/regulator/dlg,da9211-regulator.h>
>  #include <dt-bindings/gpio/gpio.h>
>  #include "mt8173.dtsi"
>  
> @@ -293,7 +294,8 @@
>  				regulator-max-microamp  = <4400000>;
>  				regulator-ramp-delay = <10000>;
>  				regulator-always-on;
> -				regulator-allowed-modes = <0 1>;
> +				regulator-allowed-modes = <DA9211_BUCK_MODE_SYNC
> +							   DA9211_BUCK_MODE_AUTO>;
>  			};
>  
>  			da9211_vgpu_reg: BUCKB {
>