Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1162109pxk; Fri, 4 Sep 2020 02:11:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4a7R3joBjpOdbYrM8dgizAUuFl3hbJSsmMDswyFBfx3BeESpQVMxfhRm68Rkr0E3C/l2x X-Received: by 2002:a17:906:60d5:: with SMTP id f21mr6302861ejk.94.1599210718611; Fri, 04 Sep 2020 02:11:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599210718; cv=none; d=google.com; s=arc-20160816; b=G4qhmUu9JkX/6zD0Wd1WKFKUNkJWtZM6Lv8ls8xQyqk3ApoMro2l8g5OnYvpbELOXG /urwHO4emeF5e2Rjck6BeUeAsp2+ShzSMjumoyAAFr8wE4f64m0Gtbz5jxMQoRjaRFTs XgzEKcXc0450x3ZmQGCRPPeudoGO8BhCzn/3T4alqkJHrHPsTIhUWdv383Lt20H+Y3KS WIBV4/1tMTG/3+XypgnSNv6RRQwWXkmYBTcejAhO88GGEoI05RlkQ2UU/dwxx2kcdtxv W+f9HuPg6Pinaoz3epnBV8TtqnynxGcy0X/ZMYCSrN8AQmQmFSHuLpSv/ET04FMjb83G PvnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:cc:to:subject:dkim-signature:dkim-filter; bh=54l8SETdxAS+gjIWH+2DCQYz9GkWo3yKuyvsIE4SZBg=; b=C0vk6Rulqy0ESLLUSx0Tr3pndltL/bkZSWEZQ6v/j00BMMo3GbBRC6LFHOvRviT1KL WwSJrYar4G5jOK4EthcgTl+WIEUp9mNosKdDtvid9xzxIZJuMsPl6f/N+NQf3MyeWfoN 8qMK0bsalpLY0XbGFS/YA/ZfMt7+6hKHsHniWwzOkrxB9Kdv+VLb40djE6/1u7lkyvYT W18yd5dn8pGxjBY464Yqm0n3yYzLyn/dGcLlssqVZcAn2NP2ZlyujyLZ199fxgrUK9NT Nnz4M10ewiBCQ8Zh6CIUz4xoXQxNEjtswHvAXUwena0vyShzwDQ0ImdyPxcjhCyF1d7y lZig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=KWjz3pED; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ng3si3482923ejb.720.2020.09.04.02.11.34; Fri, 04 Sep 2020 02:11:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=KWjz3pED; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729883AbgIDJKu (ORCPT + 99 others); Fri, 4 Sep 2020 05:10:50 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:56501 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729712AbgIDJKp (ORCPT ); Fri, 4 Sep 2020 05:10:45 -0400 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20200904091043euoutp01df15020cff826489bbaa508b67c8a72a~xiZtxwZg30989009890euoutp012 for ; Fri, 4 Sep 2020 09:10:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20200904091043euoutp01df15020cff826489bbaa508b67c8a72a~xiZtxwZg30989009890euoutp012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1599210643; bh=54l8SETdxAS+gjIWH+2DCQYz9GkWo3yKuyvsIE4SZBg=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=KWjz3pEDnOgrHXu+pMjHKB19lJGYyIJId0XhaHQPHBXYRZW6RiSzGD8xHazOVQCo2 7N0lmqolDD7FEBgt7Ia+oVoo9SU31KByr8//i2mvaU3eLsnvxmBPME7lLF3y1PtJXk 4Jsgbzb3Y8TcX4AoyE/ZyMxXXUxadCpGP5FBBknM= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20200904091043eucas1p2b9138e4464dde746fd8f8717a037d24a~xiZtjQG393034830348eucas1p2P; Fri, 4 Sep 2020 09:10:43 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 58.82.06318.394025F5; Fri, 4 Sep 2020 10:10:43 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p2.samsung.com (KnoxPortal) with ESMTPA id 20200904091042eucas1p20b93792a739ddc6627731c980ba7abbc~xiZtKDepu3022330223eucas1p2M; Fri, 4 Sep 2020 09:10:42 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200904091042eusmtrp1ecd6445472be4fde762655912639fcba~xiZtJeORq2938029380eusmtrp1L; Fri, 4 Sep 2020 09:10:42 +0000 (GMT) X-AuditID: cbfec7f5-38bff700000018ae-12-5f5204938b03 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 96.E8.06314.294025F5; Fri, 4 Sep 2020 10:10:42 +0100 (BST) Received: from [106.210.88.143] (unknown [106.210.88.143]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200904091042eusmtip15c4f202aa3b6934c463ecd12f52f7f36~xiZsq47eV1936719367eusmtip1B; Fri, 4 Sep 2020 09:10:42 +0000 (GMT) Subject: Re: Is it needed to zero out the dma buffer for DMA_ATTR_NO_KERNEL_MAPPING To: Hillf Danton , Christoph Hellwig Cc: Kees Cook , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, James Bottomley , Matthew Wilcox From: Marek Szyprowski Message-ID: Date: Fri, 4 Sep 2020 11:10:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200904022801.15828-1-hdanton@sina.com> Content-Transfer-Encoding: 7bit Content-Language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIKsWRmVeSWpSXmKPExsWy7djP87qTWYLiDe6+Y7FYufook8WBn89Z LDb2c1ic6c61uLxrDpvF/GVP2S1+/5jD5sDuMbvhIovHtEmn2Dw2r9Dy2Lyk3mP3zQY2j0kv 3D0+b5ILYI/isklJzcksSy3St0vgylh/9jJTwWTmipkP97I2MO5m6mLk5JAQMJGY1XCcsYuR i0NIYAWjxK2mucwQzhdGiV0PGpkgnM+MEsu37mKEabn99BxUy3JGiS3d+6Gc94wSj5q72UGq hAVCJY5dmA40i4NDRMBZYuZ5AZAaZoETjBIff65mAalhEzCU6HrbxQZi8wrYSfQ+/gi2gUVA RaKz6SnYgaICcRLHTj1igagRlDg58wmYzSlgJnHi/nuwemYBeYntb+cwQ9jiEreezAc7W0Jg H7vEkcdXWCDOdpE4PKEZ6gVhiVfHt7BD2DISpyf3sEA0NDNKPDy3lh3C6WGUuNw0A6rDWuLO uV9sIO8wC2hKrN+lDxF2lDg07w4LSFhCgE/ixltBiCP4JCZtg3heQoBXoqNNCKJaTWLW8XVw aw9euMQ8gVFpFpLXZiF5ZxaSd2Yh7F3AyLKKUTy1tDg3PbXYOC+1XK84Mbe4NC9dLzk/dxMj MCGd/nf86w7GfX+SDjEKcDAq8fDeeB8QL8SaWFZcmXuIUYKDWUmE1+ns6Tgh3pTEyqrUovz4 otKc1OJDjNIcLErivMaLXsYKCaQnlqRmp6YWpBbBZJk4OKUaGI9tL+0xc9N4bvJ4o+6X+x2O yeu4E+N/6ilqcxx69mTmujWze///kJDZez4uv9TrS1+22E2RP01hm6wPLYpr/9EuLiDJHO8b naqb51Onv1r58hffue+n3Zpw0/DX6h7pRcpM57vnBL15cfues9LK7OcO/1wDLxok17rvZLc6 zulYZpWU5HiuT4mlOCPRUIu5qDgRACDvXFBEAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrIIsWRmVeSWpSXmKPExsVy+t/xu7qTWILiDR7eVbNYufook8WBn89Z LDb2c1ic6c61uLxrDpvF/GVP2S1+/5jD5sDuMbvhIovHtEmn2Dw2r9Dy2Lyk3mP3zQY2j0kv 3D0+b5ILYI/SsynKLy1JVcjILy6xVYo2tDDSM7S00DMysdQzNDaPtTIyVdK3s0lJzcksSy3S t0vQy1h/9jJTwWTmipkP97I2MO5m6mLk5JAQMJG4/fQcYxcjF4eQwFJGiaMXj7JDJGQkTk5r YIWwhSX+XOtigyh6yyjx/P1VFpCEsECoxLEL05m7GDk4RAScJWaeFwAJMwucYJT4ucwDxBYS 6GSUmNAuB2KzCRhKdL0FmcPJwStgJ9H7+CMjiM0ioCLR2fQU7CBRgTiJMz0voGoEJU7OfAK2 ilPATOLE/feMEPPNJOZtfsgMYctLbH87B8oWl7j1ZD7TBEahWUjaZyFpmYWkZRaSlgWMLKsY RVJLi3PTc4sN9YoTc4tL89L1kvNzNzECo2/bsZ+bdzBe2hh8iFGAg1GJh/fG+4B4IdbEsuLK 3EOMEhzMSiK8TmdPxwnxpiRWVqUW5ccXleakFh9iNAV6biKzlGhyPjAx5JXEG5oamltYGpob mxubWSiJ83YIHIwREkhPLEnNTk0tSC2C6WPi4JRqYGzR37o7ZaZDx0LxHctnrV6TdP1qp9/G ypZZ0bW1ovqpF9yF3/f7rPj5qt/yeAH/ujMWMc51F9d7WTIxt4Sys39m9r69vz7+qQen8uMd vPGpLy00+59mP1zrJ8wV23v/r8YLIenHb93WLno37/2XFM7o3Uve5GbvYrpw4pkk60urvR5b 67dyf1FiKc5INNRiLipOBAD5Ap/c1AIAAA== X-CMS-MailID: 20200904091042eucas1p20b93792a739ddc6627731c980ba7abbc X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20200904022817eucas1p1a565e1405b27460e17ecb3447831b8ba X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20200904022817eucas1p1a565e1405b27460e17ecb3447831b8ba References: <20200904022801.15828-1-hdanton@sina.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 04.09.2020 04:28, Hillf Danton wrote: > Currently the DMA_ATTR_NO_KERNEL_MAPPING buffer allocated is not > cleared while dma core always zero it out for coherent allocations. > > Is it making sense to do memset for the attr? If it is not cleared then this is a bug. Please propose a patch fixing this issue. Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland