Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Ingo Molnar <mingo@kernel.org>,
        "Zhang\, Qiang" <Qiang.Zhang@windriver.com>
Cc:     "longman\@redhat.com" <longman@redhat.com>,
        "elver\@google.com" <elver@google.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: =?utf-8?B?5Zue5aSNOg==?= [PATCH v2] debugobjects: install cpu
 hotplug callback
In-Reply-To: <20200904055040.GA2765622@gmail.com>
References: <20200827050614.15100-1-qiang.zhang@windriver.com> <BYAPR11MB2632C578C5863019114EE572FF2D0@BYAPR11MB2632.namprd11.prod.outlook.com> <20200904055040.GA2765622@gmail.com>
Date:   Fri, 04 Sep 2020 12:26:07 +0200
Message-ID: <87k0x94z40.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 04 2020 at 07:50, Ingo Molnar wrote:
>> +#if defined(CONFIG_HOTPLUG_CPU)
>> +static int object_cpu_offline(unsigned int cpu)
>> +{
>> +       struct debug_percpu_free *percpu_pool;
>> +       struct hlist_node *tmp;
>> +       struct debug_obj *obj;
>> +
>> +       percpu_pool = per_cpu_ptr(&percpu_obj_pool, cpu);
>> +       hlist_for_each_entry_safe(obj, tmp, &percpu_pool->free_objs, node) {
>> +               hlist_del(&obj->node);
>> +               kmem_cache_free(obj_cache, obj);
>> +       }
>> +
>> +       return 0;
>> +}
>> +#endif
>
> What happens to ->obj_free, if the CPU is brought back online? Won't it be 
> out of sync at that point?

Yes and it's going to do the completely wrong thing.

Thanks,

        tglx