Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D1056C43222
Subject: Re: [PATCH v3 2/5] ASoC: dt-bindings: Add dt binding for lpass hdmi
To:     Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com,
        broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org,
        bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com,
        rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org,
        alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     V Sujith Kumar Reddy <vsujithk@codeaurora.org>
References: <1598855964-1042-1-git-send-email-srivasam@codeaurora.org>
 <1598855964-1042-3-git-send-email-srivasam@codeaurora.org>
 <0aa914dd-6a6e-208d-d29f-214a84dfd8a2@linaro.org>
From:   Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
Organization: Qualcomm India Private Limited
Message-ID: <0101017458c84d4b-5236b891-5a8c-4edb-8ff3-bd1ceac88928-000000@us-west-2.amazonses.com>
Date:   Fri, 4 Sep 2020 11:02:36 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.2.1
MIME-Version: 1.0
In-Reply-To: <0aa914dd-6a6e-208d-d29f-214a84dfd8a2@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thanks Srinivas For Review!!!

On 9/4/2020 4:11 PM, Srinivas Kandagatla wrote:
>
>
> On 31/08/2020 07:39, Srinivasa Rao Mandadapu wrote:
>> From: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>>
>> Adds bindings for lpass hdmi interface
>> which can support audio path over dp.
>>
>> Signed-off-by: Srinivasa Rao <srivasam@codeaurora.org>
>> Signed-off-by: V Sujith Kumar Reddy <vsujithk@codeaurora.org>
>> ---
>>   .../devicetree/bindings/sound/qcom,lpass-cpu.yaml  | 51 
>> ++++++++++++++++++++--
>>   1 file changed, 47 insertions(+), 4 deletions(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml 
>> b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> index 09c9bd2..7c2ac0c 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml
>> @@ -22,6 +22,7 @@ properties:
>>         - qcom,lpass-cpu
>>         - qcom,apq8016-lpass-cpu
>>         - qcom,sc7180-lpass-cpu
>> +      - qcom,sc7180-lpass-hdmi
>
> Why do we need a new compatible per interface, IMO, you should just 
> use the existing compatible.
> Or please explain the reasons why we need this?
Two compatible strings are used because iommu's are different for I2S 
and HDMI.
>
>>       reg:
>>       maxItems: 1
>> @@ -60,10 +61,12 @@ properties:
>>       const: 0
>>     patternProperties:
>> -  "(^mi2s-[0-9a-f]$|mi2s)":
>> +  "^dai@[0-9a-f]$":
>>       type: object
>> -    description: Required properties for each DAI
>> -
>> +    description: |
>> +      LPASS CPU dai node for each I2S device. Bindings of each node
>> +      depends on the specific driver providing the functionality and
>> +      properties.
>>       properties:
>>         reg:
>>           maxItems: 1
>> @@ -145,6 +148,22 @@ allOf:
>>           - iommus
>>           - power-domains
>>   +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: qcom,sc7180-lpass-hdmi
>> +    then:
>> +      properties:
>> +        clock-names:
>> +          items:
>> +            - const: pcnoc-sway-clk
>> +            - const: audio-core
>> +            - const: pcnoc-mport-clk
>> +      required:
>> +        - iommus
>> +        - power-domains
>> +
>>   examples:
>>     - |
>>       #include <dt-bindings/sound/sc7180-lpass.h>
>> @@ -178,12 +197,36 @@ examples:
>>               #address-cells = <1>;
>>               #size-cells = <0>;
>>               /* Optional to set different MI2S SD lines */
>> -            mi2s-primary@0 {
>> +            dai@mi2s-primary {
>>                   reg = <MI2S_PRIMARY>;
>>                   qcom,playback-sd-lines = <1>;
>>                   qcom,capture-sd-lines = <0>;
>>               };
>>           };
>> +
>> +        lpassh@62d87000 {
>> +            compatible = "qcom,sc7180-lpass-hdmi";
>> +
>> +            reg = <0 0x62d87000 0 0x68000>;
>> +
>> +            iommus = <&apps_smmu 0x1032 0>;
>> +
>> +            power-domains = <&lpass_hm 0>;
>> +
>> +            clocks = <&gcc 131>,
>> +                 <&lpasscc 6>,
>> +                 <&lpasscc 10>;
>> +
>> +            clock-names = "pcnoc-sway-clk", "audio-core",
>> +                          "pcnoc-mport-clk";
>> +
>> +            #sound-dai-cells = <1>;
>> +
>> +            #address-cells = <1>;
>> +            #size-cells = <0>;
>> +
>> +            interrupts = <0 268 1>;
>> +        };
>>       };
>>     ...
>>
-- 
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.