Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1292929pxk; Fri, 4 Sep 2020 06:04:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrhPWU/Os3C7R8AphkUM2Lk2B2wI5FLquVFJNOGRx93oT9g6+pjNW+CSSK03aeWEktG1EM X-Received: by 2002:a17:906:934f:: with SMTP id p15mr2816443ejw.497.1599224682635; Fri, 04 Sep 2020 06:04:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599224682; cv=none; d=google.com; s=arc-20160816; b=LnoTRaBUm6lw+eemscbkjIW/zrabUjnknDattGk+kEZsSrqKgBNjlQPmK9dnN7Bf5b oh+frPRcbWLzqibHOQtNLmImJzsWRkVb+Jx43PlkbznPzwku3J7RbeVxGsUlyHLafvRu sEid8YiDM98e+44kog7wxPgTjXsGG2bEumyxsQeh/CzCGfZplBmTgm3p3y3ma8oQs1rH b6QhTRbCfL+ilCjeYg8NBlNCnrL7/Ih1r8dPErMPNXuBRubVuWdONE80ZRS2swtjezMh Jvqb+yxVIpHPT2zNE34NmQH8C1wb+haMsIzLxsPNWIjjKjUBPXzpSaMF8xTw4tP24pKG X1pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=EJr4/0pOzIyMgNRBIBv/XOtcgAjh5svDusRASQ+9TJY=; b=CtwYm3iXPWcBuXDldEbDUxfa8xxNvFWl50g5VrzGTOtv0kHaO+3GCa1NJN2STpurap h7sTpO/nYsj8q4dc+RKGxF74RQHwYMEfcYmiEyMrf91fQRhy6zU44t7Y/kEnqsKzqOiG SmxEegmkICuiTZHWSv5RP/m8WSeDjNHOx6UbaHdjRx3HQT/TGKkWH7JmSLO+eTWY/LG4 S9O+0UfmmDB/4vRHkvp8KSPOsyoT0rjbWsTAQUTweFDv5K6pajVvC5Rda3bvHnLjWawP 58Qd2iQQFubL/Kx5NOvUYLFHW8sVu0z1vQQvxLg8XnsfVDVewgc0XGRq5o53xroHEhHZ K+4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=clSU95wH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si966758ejr.560.2020.09.04.06.04.18; Fri, 04 Sep 2020 06:04:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=clSU95wH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730374AbgIDNBa (ORCPT + 99 others); Fri, 4 Sep 2020 09:01:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730311AbgIDNAv (ORCPT ); Fri, 4 Sep 2020 09:00:51 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83D2AC061244 for ; Fri, 4 Sep 2020 06:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EJr4/0pOzIyMgNRBIBv/XOtcgAjh5svDusRASQ+9TJY=; b=clSU95wH459cRR7GBjGVumHpp2 zpLmTEy2jUnWn0DFKYJkaI4Z/7WE49Ls/EbHHzU1E7gCt3KMw38OCkJm95ue6yd92ZSTpd+UYCLD8 SVF0NwfM0bObt6ebhl8rYZgCaFgpxAJUGlMctnrrqNccn4zORLPPMB3tMd2b5ijb8fFTC2Asew+ER fHYlLf5hqN/UTQ4MgI6e8EhL+68LK78d6CSa/uBFeu/mQVv0/4ngg39Eq9J3Xb5b3zTRs//z/12SL GrkZLjpZFAf5n+8P2GH5XOIU8yV45LkFFmNB8DDV70YkaxePItCA+gBtNoQmxWbzwfkTBrkb/gqQB 6JHiDS+Q==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kEBKf-00029q-1C; Fri, 04 Sep 2020 13:00:45 +0000 Date: Fri, 4 Sep 2020 14:00:44 +0100 From: Christoph Hellwig To: Qiu Wenbo Cc: Anup Patel , Christoph Hellwig , Palmer Dabbelt , linux-riscv , Linus Torvalds , Linux Kernel Mailing List Subject: Re: [GIT PULL] RISC-V Fixes for 5.9-rc2 Message-ID: <20200904130044.GA7842@infradead.org> References: <20200904083109.GA9182@infradead.org> <20200904094617.GA27846@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2020 at 08:58:25PM +0800, Qiu Wenbo wrote: > I can confirm this patch also breaks K210 support. It seems that > csr_read(CSR_TIME) will trigger an illegal instruction exception on K210. CSR_TIME is trapped by just about every implementation I know (which is explicitly allowed by the spec). That is why we should never use it from common M-mode code.