Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] remoteproc: k3-dsp: Fix return value check in
 k3_dsp_rproc_of_get_memories()
To:     Mathieu Poirier <mathieu.poirier@linaro.org>,
        YueHaibing <yuehaibing@huawei.com>
CC:     <ohad@wizery.com>, <bjorn.andersson@linaro.org>,
        <linux-remoteproc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20200902140614.28636-1-yuehaibing@huawei.com>
 <20200902165904.GB280378@xps15>
From:   Suman Anna <s-anna@ti.com>
Message-ID: <70ad695c-4200-7927-7274-dc4d5bd32920@ti.com>
Date:   Fri, 4 Sep 2020 10:44:51 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200902165904.GB280378@xps15>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 9/2/20 11:59 AM, Mathieu Poirier wrote:
> On Wed, Sep 02, 2020 at 10:06:14PM +0800, YueHaibing wrote:
>> In case of error, the function devm_ioremap_wc() returns NULL pointer
>> not ERR_PTR(). The IS_ERR() test in the return value check should be
>> replaced with NULL test.
>>
>> Fixes: 87218f96c21a ("remoteproc: k3-dsp: Add support for C71x DSPs")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>>  drivers/remoteproc/ti_k3_dsp_remoteproc.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/remoteproc/ti_k3_dsp_remoteproc.c b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
>> index 9011e477290c..f373df35d7d0 100644
>> --- a/drivers/remoteproc/ti_k3_dsp_remoteproc.c
>> +++ b/drivers/remoteproc/ti_k3_dsp_remoteproc.c
>> @@ -445,10 +445,10 @@ static int k3_dsp_rproc_of_get_memories(struct platform_device *pdev,
>>  
>>  		kproc->mem[i].cpu_addr = devm_ioremap_wc(dev, res->start,
>>  							 resource_size(res));
>> -		if (IS_ERR(kproc->mem[i].cpu_addr)) {
>> +		if (!kproc->mem[i].cpu_addr) {
>>  			dev_err(dev, "failed to map %s memory\n",
>>  				data->mems[i].name);
>> -			return PTR_ERR(kproc->mem[i].cpu_addr);
>> +			return -EBUSY;
> 
> Shouldn't this be -ENOMEM?

Indeed, thanks for catching it.

I will fix these same issues on the K3 R5F driver for v4.

regards
Suman

> 
>>  		}
>>  		kproc->mem[i].bus_addr = res->start;
>>  		kproc->mem[i].dev_addr = data->mems[i].dev_addr;
>> -- 
>> 2.17.1
>>
>>