Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1441737pxk; Fri, 4 Sep 2020 09:25:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVjODoV39Jxk7gVtrPHxBclyT6QSDT3eWceu2mB59tofRdyFVq0cLHAdvh0yIVLjtExdSM X-Received: by 2002:aa7:d981:: with SMTP id u1mr9245221eds.250.1599236746222; Fri, 04 Sep 2020 09:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599236746; cv=none; d=google.com; s=arc-20160816; b=cVOrZ/tzJSS50mRWHHb8sObCGoEUJQNribu1fcZK1DWeDHjOmyDv3Lpsbcjfx7PnJk ekb0dPOxe01bKdqPexoXcpLrPQJgxrmMpRXmqbAjT2OZegZvvlyH+jVGXDdCHGhH6vhP tgbZdB/Gxbqy/wM+IzsNcvQ3FrixcEOfqdicqGVIunJ5GFXs78UgPRWgxSDUDoHMkKSU sbgrmyrt7Sjpnqc5ibZSvkAu08Yqva03x8bNOCwYUOj42YL2YgpKAeK0JH2O1fAQVLzd KdCtTBKaduBQ/1gggYwnxzOpiRj/3wnntQeJChYb7clHJK2Hmez17Iul45M74Zrd72RX 7Gig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=oT9KP39IABhJSqaA9F7IfiL+9b917aDqnGnO72Wfh6o=; b=oYOynEYB+TaLCVQDotbqO8Ees5stv1UKQv/Bfi8G4jyiOOFGv51KBLGWvHwMR1l9h3 Xo3jUeuEhlWkwwSG+LzAMeYU2V6+mDwGB43JJB0VBbdhqH6aNDCoqPRo0beGABS0xd88 pUQql1NQJ5X8Jx4/bGSbpeEyDBjgckI0wIh3ILRu7trgrlaMg1vg3/AccwW0yhgSZd6x mvz4C7KT3s0HZ0OS1NZaP+iojfQrClceuOCcQ+5bqIV5u0YMbZi77QTaO7lXUCx3PWUd xJ9ddZK5KGGacNuE/tkfuSCsq6lCETfwm3MzHhMEn/wJuo32NwVgpImKhwb21XIALPB1 SiMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CYBhS4JD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y22si4599878edm.265.2020.09.04.09.25.21; Fri, 04 Sep 2020 09:25:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CYBhS4JD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgIDQYi (ORCPT + 99 others); Fri, 4 Sep 2020 12:24:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:60420 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725984AbgIDQYh (ORCPT ); Fri, 4 Sep 2020 12:24:37 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C209D2067C; Fri, 4 Sep 2020 16:24:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599236677; bh=NAOttNi68dxtCKh5TVKg8sTqUmu57wOh79f7YPBx69A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CYBhS4JDiuXs0mCoO/vaMRF73YWXpersz+FpF0smRVDdj7C9Ct+RwCWCL3X2yFNpp 7RuUQEAMeqFGccOyhwlo/nsrxfWtbcHDQIrarHS1M3nKpBWnXBaE8LuoBBGgKq6XxP NCq1YqJ3YwJNIFyhB0NyeT4pw3aHQdww+TdLgZFw= Date: Fri, 4 Sep 2020 17:23:55 +0100 From: Mark Brown To: Charles Keepax Cc: Maxime Ripard , Samuel Holland , devicetree@vger.kernel.org, Jernej =?utf-8?Q?=C5=A0krabec?= , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Takashi Iwai , Liam Girdwood , Rob Herring , Marcus Cooper , Chen-Yu Tsai , peron.clem@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [linux-sunxi] [PATCH 05/16] ASoc: sun4i-i2s: Add 20 and 24 bit support Message-ID: <20200904162355.GA49830@sirena.org.uk> References: <20200704113902.336911-1-peron.clem@gmail.com> <20200704113902.336911-6-peron.clem@gmail.com> <1e320dfd-9388-54b2-dba9-7def0bf4bbad@sholland.org> <9148679.oVN3Z7rve9@kista> <20200903074023.jccqp45br3er4h3g@gilmour.lan> <20200904161649.GL10899@ediswmail.ad.cirrus.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dDRMvlgZJXvWKvBx" Content-Disposition: inline In-Reply-To: <20200904161649.GL10899@ediswmail.ad.cirrus.com> X-Cookie: Restaurant package, not for resale. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dDRMvlgZJXvWKvBx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Sep 04, 2020 at 04:16:49PM +0000, Charles Keepax wrote: > My understanding is physical_width refers to the in memory > representation, but shouldn't be used to control the slot width > on the bus. If not specified otherwise (say through the set_tdm > callback), and if the appropriate BCLK is supported, then the slot > should be just large enough to hold the data. Indeed. The framework isn't great here in tying the memory and wire formats together, ideally there would be more support for them being unrelated without DPCM. --dDRMvlgZJXvWKvBx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl9SahoACgkQJNaLcl1U h9Aivgf9FE+zKg/2HauJXtYNKTV6F5tpg9YlM9zZm1mgrfejgquDBl3k34Y9d14k 4p2wjhqoKPTGoY7Y33weRBkyBmk9KcLMfQaZRO84B1W0h1/AgaTVY8hgUbucsDld X0x3qA/ejP71NUBv1yNuMVVmhwISIg7WLJONku57+1KvdsciUFLgqcK1lesXV/hO lpemO67BlytBjZKc71yFEQtFEelOOdZmbe1GGDQtDP6wEtlzzbuJuyw9qLQBAfwC Ron6ds5hgj+K0tk7jdrtOzoW5GGN2U3d+cXn0gmQax72PwEefzjIBAR7n0TAAPcV Mh3pFSi3xyQSRAv64SY2qiJFAt8TBw== =ZBOH -----END PGP SIGNATURE----- --dDRMvlgZJXvWKvBx--