Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Sep 2020 11:12:47 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     mateusznosek0@gmail.com
Cc:     linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/page_alloc.c: Clean code by removing unnecessary
 initialization
Message-Id: <20200904111247.371e5bfca967239781e5bf27@linux-foundation.org>
In-Reply-To: <20200904132422.17387-1-mateusznosek0@gmail.com>
References: <20200904132422.17387-1-mateusznosek0@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri,  4 Sep 2020 15:24:22 +0200 mateusznosek0@gmail.com wrote:

> From: Mateusz Nosek <mateusznosek0@gmail.com>
> 
> Previously variable 'tmp' was initialized, but was not read later
> before reassigning. So the initialization can be removed.
> 
> ...
>
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5637,7 +5637,7 @@ static int find_next_best_node(int node, nodemask_t *used_node_mask)
>  	int n, val;
>  	int min_val = INT_MAX;
>  	int best_node = NUMA_NO_NODE;
> -	const struct cpumask *tmp = cpumask_of_node(0);
> +	const struct cpumask *tmp;
>  
>  	/* Use the local node if we haven't already */
>  	if (!node_isset(node, *used_node_mask)) {

OK.   But we may as well kill tmp altogether?

--- a/mm/page_alloc.c~mm-page_allocc-clean-code-by-removing-unnecessary-initialization-fix
+++ a/mm/page_alloc.c
@@ -5637,7 +5637,6 @@ static int find_next_best_node(int node,
 	int n, val;
 	int min_val = INT_MAX;
 	int best_node = NUMA_NO_NODE;
-	const struct cpumask *tmp;
 
 	/* Use the local node if we haven't already */
 	if (!node_isset(node, *used_node_mask)) {
@@ -5658,8 +5657,7 @@ static int find_next_best_node(int node,
 		val += (n < node);
 
 		/* Give preference to headless and unused nodes */
-		tmp = cpumask_of_node(n);
-		if (!cpumask_empty(tmp))
+		if (!cpumask_empty(cpumask_of_node(n)))
 			val += PENALTY_FOR_NODE_WITH_CPUS;
 
 		/* Slight preference for less loaded node */
_