Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 4 Sep 2020 12:56:28 -0700
From:   "Paul E. McKenney" <paulmck@kernel.org>
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     peterz@infradead.org, mingo@redhat.com, will@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: Question on task_blocks_on_rt_mutex()
Message-ID: <20200904195628.GL29330@paulmck-ThinkPad-P72>
Reply-To: paulmck@kernel.org
References: <20200831224911.GA13114@paulmck-ThinkPad-P72>
 <20200831232130.GA28456@paulmck-ThinkPad-P72>
 <20200901174938.GA8158@paulmck-ThinkPad-P72>
 <20200901235821.GA8516@paulmck-ThinkPad-P72>
 <20200902015128.wsulcxhbo7dutcjz@linux-p48b>
 <20200902155410.GH29330@paulmck-ThinkPad-P72>
 <20200903200639.GA8956@paulmck-ThinkPad-P72>
 <20200904172432.wgxn6x5tpnt4lcln@linux-p48b>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200904172432.wgxn6x5tpnt4lcln@linux-p48b>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Sep 04, 2020 at 10:24:32AM -0700, Davidlohr Bueso wrote:
> On Thu, 03 Sep 2020, Paul E. McKenney wrote:
> 
> > commit d93a64389f4d544ded241d0ba30b2586497f5dc0
> > Author: Paul E. McKenney <paulmck@kernel.org>
> > Date:   Tue Sep 1 16:58:41 2020 -0700
> > 
> >    torture: Periodically pause in stutter_wait()
> > 
> >    Running locktorture scenario LOCK05 results in hangs:
> > 
> >    tools/testing/selftests/rcutorture/bin/kvm.sh --allcpus --torture lock --duration 3 --configs LOCK05
> > 
> >    The lock_torture_writer() kthreads set themselves to MAX_NICE while
> >    running SCHED_OTHER.  Other locktorture kthreads run at default niceness,
> >    also SCHED_OTHER.  This results in these other locktorture kthreads
> >    indefinitely preempting the lock_torture_writer() kthreads.  Note that
> >    the cond_resched() in the stutter_wait() function's loop is ineffective
> >    because this scenario is built with CONFIG_PREEMPT=y.
> > 
> >    It is not clear that such indefinite preemption is supposed to happen, but
> >    in the meantime this commit prevents kthreads running in stutter_wait()
> >    from being completely CPU-bound, thus allowing the other threads to get
> >    some CPU in a timely fashion.  This commit also uses hrtimers to provide
> >    very short sleeps to avoid degrading the sudden-on testing that stutter
> >    is supposed to provide.
> > 
> >    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> 
> Reviwed-by: Davidlohr Bueso <dbueso@suse.de>

Applied, thank you!

							Thanx, Paul