Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1625494pxk; Fri, 4 Sep 2020 14:35:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwVqsvrri8hXshVOYQfesJVFH2tScHKYr1L1Nm2k42KlO3zM3I9ku4mEm8qg2/etrFRAZK8 X-Received: by 2002:aa7:cad7:: with SMTP id l23mr10996950edt.58.1599255344106; Fri, 04 Sep 2020 14:35:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599255344; cv=none; d=google.com; s=arc-20160816; b=rAW/hPezTirVhyHIi0NHAayv4aSXeb7TbaLGpPGgMnwZcBKGNvc7gDSlzP9V+CodgS kyETIEUw6Qa/pQXO5L7ekoD5RFGFvS63W51BAiWS4xPNFDLX+ia1pe449IAVSuXzsrKN 5eGjeOsGLs6AgtyDCF19hZViXUr+0Vsh/0okVfctIsMGzG4k8iR7jtfvLzqfrHxKNlLc /53inwBABb0PuPGH52B9l5k7LCf3oX88Gbv4eAXgsoOlZ+Xf41JhvKxDFyc72vGuxSWE 4ImV1iEvWW9yP6vbIMfGSx22evIPuwTO0dXLf02oTZTSti0JF/wrAL5vqcqe14O4aN3e DniQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:user-agent :mime-version:date:references:in-reply-to:cc:to:from:subject :message-id; bh=uxbd6GlA3vCqEfHrIuTYzTFZ7E1+EA688A4puRTAa84=; b=mosXbLUkAQefxqTqMCyDOG8KRvxgaFcCmOQjvBluxeomnXlQyWjzfPYRQ+BztOFAzK LWkcMmm8aNC/3Rjam+LqNxf+653T2dT40sJhCxPGYaK6JbJVhWFwDPclQG1OZnkLnhQf 9aIjwM1MCSu27Gq5zllSsx6eeAt9pOS5FipgT6uJUQLHncdL4eDhheqcp0frfarpXHqJ NHjhMeoEIcBcE85hzhComkkatr5XteUimHUIFWsrEgeje/sHSPy1rckTUi7LBPeD6oUc jIjZY78Y287o28iH9srCKrO5zVvtbIMz+lJHzIoIqooYEK69Ikh7r+r6+Vlo47E7bBeR 0Apw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p1si5050168ejr.342.2020.09.04.14.35.20; Fri, 04 Sep 2020 14:35:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728141AbgIDVeM (ORCPT + 99 others); Fri, 4 Sep 2020 17:34:12 -0400 Received: from smtprelay0198.hostedemail.com ([216.40.44.198]:39058 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727020AbgIDVeI (ORCPT ); Fri, 4 Sep 2020 17:34:08 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay03.hostedemail.com (Postfix) with ESMTP id 75B528384365; Fri, 4 Sep 2020 21:34:04 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,joe@perches.com,,RULES_HIT:41:355:379:599:967:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1537:1566:1593:1594:1711:1714:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2828:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3622:3865:3867:3868:3870:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:5007:7903:9025:10004:10400:10848:11232:11658:11914:12043:12048:12297:12555:12663:12679:12740:12760:12895:13069:13161:13229:13311:13357:13439:14181:14659:14721:21080:21627:21740:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:1,LUA_SUMMARY:none X-HE-Tag: brain20_590dcfc270b5 X-Filterd-Recvd-Size: 1527 Received: from XPS-9350.home (unknown [47.151.133.149]) (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA; Fri, 4 Sep 2020 21:34:02 +0000 (UTC) Message-ID: Subject: Re: [PATCH 08/29] dma-buf: Avoid comma separated statements From: Joe Perches To: kieran.bingham+renesas@ideasonboard.com, Jiri Kosina , Sumit Semwal , Christian =?ISO-8859-1?Q?K=F6nig?= Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org In-Reply-To: References: <990bf6f33ccaf73ad56eb4bea8bd2c0db5e90a31.1598331148.git.joe@perches.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Fri, 04 Sep 2020 14:33:52 -0700 MIME-Version: 1.0 User-Agent: Evolution 3.36.4-0ubuntu1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-09-04 at 12:42 +0100, Kieran Bingham wrote: > I'm pleased to see this is treewide ;-) > Definitely prefer this. These are only the comma uses in if/do/while blocks that would also need braces as separate statements. There a multiple dozens more just with single statements terminated by commas and not semicolons. See: https://lore.kernel.org/patchwork/patch/1291033/