Received: by 2002:a05:6a10:22f:0:0:0:0 with SMTP id 15csp1681899pxk; Fri, 4 Sep 2020 16:31:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDy6wLgDBp3+BHhw2wATw01l1BYUodQmIqZXGzBcopga1eEDmIsU6Lk3h9//HHAKYFlGgE X-Received: by 2002:a17:906:1fd6:: with SMTP id e22mr9791011ejt.17.1599262263205; Fri, 04 Sep 2020 16:31:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1599262263; cv=none; d=google.com; s=arc-20160816; b=EfheBnT7m3ou7pNbtvf97enAtz47NwN3vsH3QNCeCcscnNkmdWfpWblrfA421kcbDz bh2dDJhRCoMq0yMjQ98mic1I/Pg3lm1QZgHjNjb7YmEe0v0k8ZHTShE7mmQNe4MksCM2 9KCHH4ljoef8lBQFqr/vtaVq6Sg+IPCyd4IvzMLShLzQlO4jPqMXyMRsjUxcGcUKjvDI +4nIN4OYXjlFzl6Usf35P7lmPdZi8ZR16RzK72wwXGP45z8OqU+M8gDRvMcX11viA4zw Vsa2SZMuleWDq4vTZCXKpAqIwsamZXEHkJOzdc2q59nmPknZwUQCr95CKibymcskWQpA SXsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:from:references:in-reply-to :message-id:cc:to; bh=XL8Kef4p8peZwHnfqm7k1BHZdh6kDKSRJTwuohEdj4o=; b=u1c9C3NLLrRo/n4WWiKwHaMGxVV/6wAhnu7vJtE4OFSrFjI3KVsX/E9JQUafDCBXki RyAnD7kAmbsQYkxsbprAqcPaF84rZU6Rpz3Igri0bgMoDXujh2Qdnn7uXSLi8FRo53Md 8FA02yq7Fa7UucLdrcxa9CE1oKoeOXza5TgAf+uJDORMvVE6OR1+I5amL3of70FIqj9d wYhBMYBZKESfxSged9piVq2r55mmMm1qzEe4k6WLsBy5q015ffnP67HKtnzWPorQjAgg AKAv+VWPbLrf7/dVJ4UFD53iwoLfQxdzDjfcftGfeTJQDjF29BNn4DC69YVm1RCveSM/ WH3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay11si5048364edb.517.2020.09.04.16.30.41; Fri, 04 Sep 2020 16:31:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728343AbgIDX0x (ORCPT + 99 others); Fri, 4 Sep 2020 19:26:53 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:34872 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728269AbgIDX02 (ORCPT ); Fri, 4 Sep 2020 19:26:28 -0400 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id DC54E2ACD6; Fri, 4 Sep 2020 19:26:27 -0400 (EDT) To: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: References: From: Finn Thain Subject: [PATCH 3/5] powerpc/tau: Remove duplicated set_thresholds() call Date: Sat, 05 Sep 2020 09:02:20 +1000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The commentary at the call site seems to disagree with the code. The conditional prevents calling set_thresholds() via the exception handler, which appears to crash. Perhaps that's because it immediately triggers another TAU exception. Anyway, calling set_thresholds() from TAUupdate() is redundant because tau_timeout() does so. Fixes: 1da177e4c3f41 ("Linux-2.6.12-rc2") Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/powerpc/kernel/tau_6xx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/kernel/tau_6xx.c b/arch/powerpc/kernel/tau_6xx.c index 268205cc347da..b8d7e7d498e0a 100644 --- a/arch/powerpc/kernel/tau_6xx.c +++ b/arch/powerpc/kernel/tau_6xx.c @@ -110,11 +110,6 @@ static void TAUupdate(int cpu) #ifdef DEBUG printk("grew = %d\n", tau[cpu].grew); #endif - -#ifndef CONFIG_TAU_INT /* tau_timeout will do this if not using interrupts */ - set_thresholds(cpu); -#endif - } #ifdef CONFIG_TAU_INT -- 2.26.2