Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Paul Cercueil <paul@crapouillou.net>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Cristian Birsan <cristian.birsan@microchip.com>,
        Felipe Balbi <balbi@kernel.org>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Ludovic Desroches <ludovic.desroches@microchip.com>,
        Avi Fishman <avifishman70@gmail.com>,
        Tomer Maimon <tmaimon77@gmail.com>,
        Tali Perry <tali.perry1@gmail.com>,
        Patrick Venture <venture@google.com>,
        Nancy Yuen <yuenn@google.com>,
        Benjamin Fair <benjaminfair@google.com>,
        Alan Stern <stern@rowland.harvard.edu>,
        Tony Prisk <linux@prisktech.co.nz>, Bin Liu <b-liu@ti.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH 06/20] usb/chipidea: core: Use pm_ptr() macro
Thread-Topic: [PATCH 06/20] usb/chipidea: core: Use pm_ptr() macro
Thread-Index: AQHWgeUeVblSA116M06WTywDJrW2qalZK9WA
Date:   Sat, 5 Sep 2020 00:02:39 +0000
Message-ID: <20200905000215.GA24243@b29397-desktop>
References: <20200903112554.34263-1-paul@crapouillou.net>
 <20200903112554.34263-7-paul@crapouillou.net>
In-Reply-To: <20200903112554.34263-7-paul@crapouillou.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <0D0BEEEC3F31194C8DD1C1705C70F150@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e1f6d5bb-1382-436d-cb3b-08d8512f00f6
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2020 00:02:39.2778
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kZ5h2kYETF/pBlR7pzdqj90o/r8ZGdjQo+rib/UroNWYoXI5S0aBZl3G8XLlugayNyYTBdWVRuUjFs7unUldkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5605
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-09-03 13:25:40, Paul Cercueil wrote:
> Use the newly introduced pm_ptr() macro, and mark the suspend/resume
> functions __maybe_unused. These functions can then be moved outside the
> CONFIG_PM_SUSPEND block, and the compiler can then process them and
> detect build failures independently of the config. If unused, they will
> simply be discarded by the compiler.

For using __maybe_unused or using MACRO, it depends. The chipidea core
has many functions are only used for power management, you need to add
__maybe_unused for everyone of them, I still prefer using MACRO.

Peter
>=20
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  drivers/usb/chipidea/core.c | 26 +++++++++++---------------
>  1 file changed, 11 insertions(+), 15 deletions(-)
>=20
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index aa40e510b806..af64ab98fb56 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -1231,9 +1231,8 @@ static int ci_hdrc_remove(struct platform_device *p=
dev)
>  	return 0;
>  }
> =20
> -#ifdef CONFIG_PM
>  /* Prepare wakeup by SRP before suspend */
> -static void ci_otg_fsm_suspend_for_srp(struct ci_hdrc *ci)
> +static void __maybe_unused ci_otg_fsm_suspend_for_srp(struct ci_hdrc *ci=
)
>  {
>  	if ((ci->fsm.otg->state =3D=3D OTG_STATE_A_IDLE) &&
>  				!hw_read_otgsc(ci, OTGSC_ID)) {
> @@ -1245,7 +1244,7 @@ static void ci_otg_fsm_suspend_for_srp(struct ci_hd=
rc *ci)
>  }
> =20
>  /* Handle SRP when wakeup by data pulse */
> -static void ci_otg_fsm_wakeup_by_srp(struct ci_hdrc *ci)
> +static void __maybe_unused ci_otg_fsm_wakeup_by_srp(struct ci_hdrc *ci)
>  {
>  	if ((ci->fsm.otg->state =3D=3D OTG_STATE_A_IDLE) &&
>  		(ci->fsm.a_bus_drop =3D=3D 1) && (ci->fsm.a_bus_req =3D=3D 0)) {
> @@ -1259,7 +1258,7 @@ static void ci_otg_fsm_wakeup_by_srp(struct ci_hdrc=
 *ci)
>  	}
>  }
> =20
> -static void ci_controller_suspend(struct ci_hdrc *ci)
> +static void __maybe_unused ci_controller_suspend(struct ci_hdrc *ci)
>  {
>  	disable_irq(ci->irq);
>  	ci_hdrc_enter_lpm(ci, true);
> @@ -1277,7 +1276,7 @@ static void ci_controller_suspend(struct ci_hdrc *c=
i)
>   * interrupt (wakeup int) only let the controller be out of
>   * low power mode, but not handle any interrupts.
>   */
> -static void ci_extcon_wakeup_int(struct ci_hdrc *ci)
> +static void __maybe_unused ci_extcon_wakeup_int(struct ci_hdrc *ci)
>  {
>  	struct ci_hdrc_cable *cable_id, *cable_vbus;
>  	u32 otgsc =3D hw_read_otgsc(ci, ~0);
> @@ -1294,7 +1293,7 @@ static void ci_extcon_wakeup_int(struct ci_hdrc *ci=
)
>  		ci_irq(ci->irq, ci);
>  }
> =20
> -static int ci_controller_resume(struct device *dev)
> +static int __maybe_unused ci_controller_resume(struct device *dev)
>  {
>  	struct ci_hdrc *ci =3D dev_get_drvdata(dev);
>  	int ret;
> @@ -1332,8 +1331,7 @@ static int ci_controller_resume(struct device *dev)
>  	return 0;
>  }
> =20
> -#ifdef CONFIG_PM_SLEEP
> -static int ci_suspend(struct device *dev)
> +static int __maybe_unused ci_suspend(struct device *dev)
>  {
>  	struct ci_hdrc *ci =3D dev_get_drvdata(dev);
> =20
> @@ -1366,7 +1364,7 @@ static int ci_suspend(struct device *dev)
>  	return 0;
>  }
> =20
> -static int ci_resume(struct device *dev)
> +static int __maybe_unused ci_resume(struct device *dev)
>  {
>  	struct ci_hdrc *ci =3D dev_get_drvdata(dev);
>  	int ret;
> @@ -1386,9 +1384,8 @@ static int ci_resume(struct device *dev)
> =20
>  	return ret;
>  }
> -#endif /* CONFIG_PM_SLEEP */
> =20
> -static int ci_runtime_suspend(struct device *dev)
> +static int __maybe_unused ci_runtime_suspend(struct device *dev)
>  {
>  	struct ci_hdrc *ci =3D dev_get_drvdata(dev);
> =20
> @@ -1408,13 +1405,12 @@ static int ci_runtime_suspend(struct device *dev)
>  	return 0;
>  }
> =20
> -static int ci_runtime_resume(struct device *dev)
> +static int __maybe_unused ci_runtime_resume(struct device *dev)
>  {
>  	return ci_controller_resume(dev);
>  }
> =20
> -#endif /* CONFIG_PM */
> -static const struct dev_pm_ops ci_pm_ops =3D {
> +static const struct dev_pm_ops __maybe_unused ci_pm_ops =3D {
>  	SET_SYSTEM_SLEEP_PM_OPS(ci_suspend, ci_resume)
>  	SET_RUNTIME_PM_OPS(ci_runtime_suspend, ci_runtime_resume, NULL)
>  };
> @@ -1424,7 +1420,7 @@ static struct platform_driver ci_hdrc_driver =3D {
>  	.remove	=3D ci_hdrc_remove,
>  	.driver	=3D {
>  		.name	=3D "ci_hdrc",
> -		.pm	=3D &ci_pm_ops,
> +		.pm	=3D pm_ptr(&ci_pm_ops),
>  		.dev_groups =3D ci_groups,
>  	},
>  };
> --=20
> 2.28.0
>=20

--=20

Thanks,
Peter Chen=